offload the language loading mechanism to the frontend #92
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sylensky
force-pushed
the
bugfix/lang-memory
branch
from
b0bc18f to
5b87ec9
Compare
…essing Moved language string replacement from server to client to reduce memory usage and eliminate heap fragmentation from string concatenation. This saves us ram usage for other features.
Sylensky
force-pushed
the
bugfix/lang-memory
branch
from
5b87ec9 to
3c9db68
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of wasting memory on the esp32 we use now the browser of the client to resolve the selected language.
Let it initially fetch all language strings that then get replaced dynamically. This adds a little loading time between each switch where the screen goes blank but that is a worthy tradeoff for giving back alot of internal memory.