attempt to fix goto functionality #91
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is an attempt to fix the goto functionality to move into the right direction. It uncovered alot of work below to clarify used variables in the context. What was actually necessary to make goto pan into the right direction is overwriting the absolute direction, setting the drivers direction directly. Furthermore goto didn't stop when the target was reached as the counting did not behave as expected with a bunch of microstepping conversion.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an attempt to fix the goto functionality to move into the
right direction. It uncovered alot of work below to clarify used
variables in the context.
What was actually necessary to make goto pan into the right direction
is overwriting the absolute direction, setting the drivers
direction directly.
Furthermore goto didn't stop when the target was reached as the counting
did not behave as expected with a bunch of microstepping conversion.