Fix #308: Notification badge shows red indicator when unread count is 0#314
Fix #308: Notification badge shows red indicator when unread count is 0#314Bolajiomo99 wants to merge 1 commit into
Conversation
… count is 0 - Changed badge condition from to in AppHeader.tsx - Created /app/notifications page so 'View all notifications' link navigates correctly
Josue19-08
left a comment
Josue19-08
left a comment
There was a problem hiding this comment.
The badge fix in AppHeader.tsx is correct — changing the condition from {true && ( to {unreadCount > 0 && (} is exactly right. Two issues need to be addressed:
-
Out-of-scope change. src/app/app/notifications/page.tsx (+147 lines) adds a full notifications page with infinite scroll, mark-all-as-read, and empty state. Issue #308 is specifically about the badge condition — this new page is a separate feature that should be tracked in its own issue and PR. Please remove it from this PR.
-
PR template not properly formatted. The body mixes a custom description at the top with template content below. Please restructure using the template from .github/PULL_REQUEST_TEMPLATE.md — the description and changes should be inside the template sections, not before it.
|
Completed |
2 participants
Description
This pull request fixes two bugs in the notification system: the red dot badge showing when the unread count is 0, and the "View all notifications" link navigating nowhere.
Changes made
Changed badge condition from {true && ( to {unreadCount > 0 && (} in AppHeader.tsx
Created /app/notifications page so "View all notifications" link navigates correctly
🚀 Pull Request
🔧 Title:
Fix: Notification badge shows red indicator when unread count is 0
🛠️ Issue
Closes Fix: Notification badge shows red indicator when unread count is 0 #308
📚 Description
The notification badge on the dashboard nav shows a red dot indicator even when the unread notification count is 0. Additionally, the "View all notifications" link/button does not navigate to the notifications page — clicking it does nothing. Reported by testers in manual test #1361.
✅ Changes applied
🔍 Evidence/Media (screenshots/videos)