-
Notifications
You must be signed in to change notification settings - Fork 5
QA Spec #225
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
QA Spec #225
Changes from 7 commits
Commits
Show all changes
57 commits
Select commit
Hold shift + click to select a range
e2d4038
wip
kba 0cc4a0b
Merge remote-tracking branch 'origin/master' into qa-spec
kba 5aa6bd5
rewrite eval schema and saple according to OCR-D/zenhub#123
kba 6cd0caf
add metrics to ocrd_eval.md
kba b529531
ocrd_eval: \begin{array}{ll} instead of .. {2}
kba 18333b8
style(ocrd_eval.md): linting, formatting and correcting images
mweidling fe9d6ff
stlye: add new line
mweidling d7854a1
Apply suggestions from code review
kba ee67881
Apply suggestions from code review
kba 5b35358
retcon JSON changes to YAML
mweidling 1aa048c
comment EvaluationMetrics back in
kba 5840476
generate minimal JSON from YAML src
kba c9d313f
comment out undiscussed CER metrics
mweidling a814c89
feat: move workflow_steps to ocr_workflow object
mweidling a881e08
remove schema from this branch, cf. #236
kba c7ae88d
integrate Uwe's feedback
mweidling 7ce6c1a
Update ocrd_eval.md
mweidling ef8aeea
Update ocrd_eval.md
mweidling e2d2ec9
Update ocrd_eval.md
mweidling ad97594
Update ocrd_eval.md
mweidling 34a78cb
Update ocrd_eval.md
mweidling c95ce0b
Update ocrd_eval.md
mweidling 13b2bcd
Update ocrd_eval.md
mweidling b823afc
Update ocrd_eval.md
mweidling 8ab1391
Apply suggestions from code review
mweidling 5e1da31
Apply suggestions from code review
mweidling 0183ea9
Update ocrd_eval.md
mweidling 5519120
update character definition wrt. white spaces
mweidling dd2d63b
refine paragraph about characters
mweidling 0253720
move character section before edit distance section
mweidling 19deddd
add placeholder for letter accuracy
mweidling 149b271
fix link
mweidling 7d0bbf6
Update ocrd_eval.md
mweidling 851aeb7
Update ocrd_eval.md
mweidling c81079a
Update ocrd_eval.md
mweidling fab6202
Update ocrd_eval.md
mweidling f678050
implement feedback
mweidling a680c70
be more precise about CER/WER granularity
mweidling 5e94aa0
change GPU metrics
mweidling e8dc864
change citation hint
mweidling ee330c9
adjust WER definition
mweidling 9ea4b62
Apply suggestions from code review
mweidling c910f0e
add bow metric
mweidling 8c22169
format document
mweidling 149a2eb
gpu mem instead of util
mweidling 2999ef4
Update ocrd_eval.md
mweidling 87f9438
GPU Peak Memory definition
mweidling 5e80c94
Update ocrd_eval.md
mweidling 5cd5efb
Update ocrd_eval.md
mweidling 492b6ee
Update ocrd_eval.md
mweidling d8d4cef
Update ocrd_eval.md
mweidling 48e69f8
add letter accuracy
mweidling 3cc5bee
rephrase layout eval intro
mweidling f817521
add reading order evaluation
mweidling 04c5c27
implement Uwe's feedback reg. Letter Accuracy
mweidling d078b1b
Apply suggestions from code review
mweidling 43b364a
eval: Improvements to TeX formulas
kba File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,10 +1,10 @@ | ||
json: \ | ||
bagit-profile.json \ | ||
ocrd_tool.schema.json \ | ||
openapi.json | ||
|
||
deps: | ||
pip install yaml click | ||
json: $(shell find -name '*.json') | ||
|
||
%.json: %.yml | ||
python3 scripts/yaml-to-json.py $< $@ | ||
|
||
validate: json | ||
jsonschema --output pretty --validator Draft201909Validator --instance ocrd_eval.sample.json ocrd_eval.schema.json | ||
|
||
deps: | ||
pip install yaml click jsonschema |
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,120 @@ | ||
[ | ||
{ | ||
"@id": "https://github.com/OCR-D/quiver/tree/data/evaluations/wf1-data345-eval1.json", | ||
"label": "OCR workflow 1 on workspace 345", | ||
"metadata": { | ||
"ocr_workflow": { | ||
"@id": "https://github.com/OCR-D/quiver/tree/data/workflows/1.nf", | ||
"label": "OCR Workflow 1" | ||
}, | ||
"eval_workflow": { | ||
"@id": "https://github.com/OCR-D/quiver/tree/data/workflows/eval1.nf", | ||
"label": "Evaluation Workflow 1" | ||
}, | ||
"gt_workspace": { | ||
"@id": "https://gt.ocr-d.de/workspace/789", | ||
"label": "GT workspace 789 (19th century fraktur)" | ||
}, | ||
"ocr_workspace": { | ||
"@id": "https://github.com/OCR-D/quiver/tree/data/workspaces/3000.ocrd.zip", | ||
"label": "OCR result workspace 3000" | ||
}, | ||
"eval_workspace": { | ||
"@id": "https://github.com/OCR-D/quiver/tree/data/workspaces/345.ocrd.zip", | ||
"label": "Evaluation Workspace 345" | ||
}, | ||
"workflow_steps": { | ||
"0": "Processor A", | ||
"1": "Processor B" | ||
}, | ||
"workflow_model": "Fraktur_GT4HistOCR", | ||
"document_metadata": { | ||
"fonts": [ | ||
"antiqua", | ||
"fraktur" | ||
], | ||
"publication_century": "1800-1900", | ||
"publication_decade": "1850-1860", | ||
"publication_year": 1855, | ||
"number_of_pages": 100, | ||
"layout": "simple" | ||
} | ||
}, | ||
"evaluation": { | ||
"document_wide": { | ||
"wall_time": 1234, | ||
"cer": 0.57, | ||
"cer_min_max": [ | ||
0.2, | ||
0.57 | ||
] | ||
}, | ||
"by_page": [ | ||
{ | ||
"page_id": "PHYS_0001", | ||
"cer": 0.8, | ||
"processing_time": 2.1 | ||
} | ||
] | ||
} | ||
}, | ||
{ | ||
"@id": "https://github.com/OCR-D/quiver/tree/data/evaluations/wf2-data345-eval1.json", | ||
"label": "OCR Workflow 2 on Data 345", | ||
"metadata": { | ||
"ocr_workflow": { | ||
"@id": "https://github.com/OCR-D/quiver/tree/data/workflows/2.nf", | ||
"label": "OCR Workflow 2" | ||
}, | ||
"eval_workflow": { | ||
"@id": "https://github.com/OCR-D/quiver/tree/data/workflows/eval1.nf", | ||
"label": "Evaluation Workflow 1" | ||
}, | ||
"gt_workspace": { | ||
"@id": "https://gt.ocr-d.de/workspace/789", | ||
"label": "GT workspace 789 (19th century fraktur)" | ||
}, | ||
"ocr_workspace": { | ||
"@id": "https://github.com/OCR-D/quiver/tree/data/workspaces/3000.ocrd.zip", | ||
"label": "OCR result workspace 3000" | ||
}, | ||
"eval_workspace": { | ||
"@id": "https://github.com/OCR-D/quiver/tree/data/workspaces/345.ocrd.zip", | ||
"label": "Evaluation Workspace 345" | ||
}, | ||
"workflow_steps": { | ||
"0": "Processor A", | ||
"1": "Processor B" | ||
}, | ||
"workflow_model": "Fraktur_GT4HistOCR", | ||
"document_metadata": { | ||
"fonts": [ | ||
"antiqua", | ||
"fraktur" | ||
], | ||
"publication_century": "1800-1900", | ||
"publication_decade": "1850-1860", | ||
"publication_year": 1855, | ||
"number_of_pages": 100, | ||
"layout": "simple" | ||
} | ||
}, | ||
"evaluation": { | ||
"document_wide": { | ||
"wall_time": 4567, | ||
"cer": 0.9, | ||
"cer_min_max": [ | ||
0.2, | ||
0.99 | ||
] | ||
}, | ||
"by_page": [ | ||
{ | ||
"page_id": "PHYS_0001", | ||
"cer": 0.9, | ||
"processing_time": 2.1 | ||
} | ||
] | ||
} | ||
} | ||
] |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,85 @@ | ||
- '@id': https://github.com/OCR-D/quiver/tree/data/evaluations/wf1-data345-eval1.json | ||
label: OCR workflow 1 on workspace 345 | ||
metadata: | ||
ocr_workflow: | ||
'@id': https://github.com/OCR-D/quiver/tree/data/workflows/1.nf | ||
label: OCR Workflow 1 | ||
eval_workflow: | ||
'@id': https://github.com/OCR-D/quiver/tree/data/workflows/eval1.nf | ||
label: Evaluation Workflow 1 | ||
gt_workspace: | ||
'@id': https://gt.ocr-d.de/workspace/789 | ||
label: GT workspace 789 (19th century fraktur) | ||
ocr_workspace: | ||
'@id': https://github.com/OCR-D/quiver/tree/data/workspaces/3000.ocrd.zip | ||
label: OCR result workspace 3000 | ||
eval_workspace: | ||
'@id': https://github.com/OCR-D/quiver/tree/data/workspaces/345.ocrd.zip | ||
label: Evaluation Workspace 345 | ||
workflow_steps: | ||
'0': Processor A | ||
'1': Processor B | ||
workflow_model: Fraktur_GT4HistOCR | ||
document_metadata: | ||
fonts: | ||
- antiqua | ||
- fraktur | ||
publication_century: 1800-1900 | ||
publication_decade: 1850-1860 | ||
publication_year: 1855 | ||
number_of_pages: 100 | ||
layout: simple | ||
evaluation: | ||
document_wide: | ||
wall_time: 1234 | ||
cer: 0.57 | ||
cer_min_max: | ||
- 0.2 | ||
- 0.57 | ||
by_page: | ||
- page_id: PHYS_0001 | ||
cer: 0.8 | ||
processing_time: 2.1 | ||
|
||
- '@id': https://github.com/OCR-D/quiver/tree/data/evaluations/wf2-data345-eval1.json | ||
label: OCR Workflow 2 on Data 345 | ||
metadata: | ||
ocr_workflow: | ||
'@id': https://github.com/OCR-D/quiver/tree/data/workflows/2.nf | ||
label: OCR Workflow 2 | ||
eval_workflow: | ||
'@id': https://github.com/OCR-D/quiver/tree/data/workflows/eval1.nf | ||
label: Evaluation Workflow 1 | ||
gt_workspace: | ||
'@id': https://gt.ocr-d.de/workspace/789 | ||
label: GT workspace 789 (19th century fraktur) | ||
ocr_workspace: | ||
'@id': https://github.com/OCR-D/quiver/tree/data/workspaces/3000.ocrd.zip | ||
label: OCR result workspace 3000 | ||
eval_workspace: | ||
'@id': https://github.com/OCR-D/quiver/tree/data/workspaces/345.ocrd.zip | ||
label: Evaluation Workspace 345 | ||
workflow_steps: | ||
'0': Processor A | ||
'1': Processor B | ||
workflow_model: Fraktur_GT4HistOCR | ||
document_metadata: | ||
fonts: | ||
- antiqua | ||
- fraktur | ||
publication_century: 1800-1900 | ||
publication_decade: 1850-1860 | ||
publication_year: 1855 | ||
number_of_pages: 100 | ||
layout: simple | ||
evaluation: | ||
document_wide: | ||
wall_time: 4567 | ||
cer: 0.9 | ||
cer_min_max: | ||
- 0.2 | ||
- 0.99 | ||
by_page: | ||
- page_id: PHYS_0001 | ||
cer: 0.9 | ||
processing_time: 2.1 |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.