use-internal-oauth-proxy-image will only apply to pods that have an oauth-proxy container already present #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…auth-proxy container already present Currently the use-internal-oauth-proxy-image policy will apply to all pods even if they don't have an oauth-proxy container. This leads to issues with pods created from sources other than RHOAI since it tries to pull the oauth-proxy image when it should not be. This PR will make it so this policy only applies to pods with an oauth-proxy container already present. Signed-off-by: Isaiah Stapleton <[email protected]>
larsks
approved these changes
Sep 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the use-internal-oauth-proxy-image policy will apply to all pods even if they don't have an oauth-proxy container. This leads to issues with pods created from sources other than RHOAI since it tries to pull the oauth-proxy image when it should not be. This PR will make it so this policy only applies to pods with an oauth-proxy container already present.