[FIX][14.0] shopfloor cluster_picking: fix line split #986
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmequignon
force-pushed
the
14.0_shopfloor_fix_line_split
branch
from
f511a2e to
21f31bf
Compare
mt-software-de
suggested changes
Feb 19, 2025
|
|
||
| # Keeping second return value for compatibility | ||
| # Quantity already checked at _check_line_qty_processible | ||
| new_line, __ = move_line._split_qty_to_be_done(quantity) |
There was a problem hiding this comment.
Could you also extend test_scan_destination_pack_bin_not_found and ensure that there is also no new stock.move.line created.
Because by moving _split_qty_to_be_done you fixed also the problem, that there is a stock.move.line created, when a wrong barcode is scanned and you entered a lower qty as product_uom_qty.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At
scan_destination_packwhen a destination package is scanned without any qty processed (especially when no prefill quantity is enabled), we would end up with a new move line with qty = 0.Instead, return an error to the user.