[14.0] stock_available_to_promise_release: Allow unrelease processed qties #971
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbaudoux
requested changes
Jan 15, 2025
stock_available_to_promise_release/models/stock_location_route.py
Outdated
Show resolved
Hide resolved
stock_available_to_promise_release/models/stock_location_route.py
Outdated
Show resolved
Hide resolved
mmequignon
force-pushed
the
14-unrelease_reverse_qty_done
branch
from
b5ad9ef to
f6cf4c7
Compare
jbaudoux
reviewed
Jan 28, 2025
| returned_qty = moves_to_return._return_quantity_in_stock( | ||
| qty_to_return_at_step | ||
| ) | ||
| qty_returned_for_move += returned_qty |
There was a problem hiding this comment.
I would move this before the block just after the if float_is_zero
qty_returned_for_move += qty_to_return_at_step
There was a problem hiding this comment.
I don't think we should.
Break only breaks this loop, but this qty_returned_for_move must be up to date for the outter one, which relies on this variable to determine how many remaining units has to be returned.
Maybe I'm missing something.
mmequignon
force-pushed
the
14-unrelease_reverse_qty_done
branch
from
f6cf4c7 to
eb6a8f5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new option on stock routes, allowing to unrelease a delivery even if some internal operations (e.g. pick) are already done, creating a return move to the stock location.