[17.0][FIX] web_responsive: Make showAppsMenuItem work again #3069
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carlos-lopez-tecnativa
force-pushed
the
17.0-fix-web_responsive_tours
branch
from
60983e9 to
1f7f416
Compare
sergio-teruel
suggested changes
Jan 27, 2025
In Odoo 17, the Class TourStepUtils was removed, and stepUtils is now an object instead of a class. When this module is installed, the tours stop working and throw the error:
Uncaught Error: Dependencies should be defined by an array: function (require) {.
This commit adapts the code to align with these changes, ensuring that tours work correctly.
carlos-lopez-tecnativa
force-pushed
the
17.0-fix-web_responsive_tours
branch
from
1f7f416 to
50c8ade
Compare
pedrobaeza
approved these changes
Jan 27, 2025
|
This PR looks fantastic, let's merge it! |
|
Congratulations, your PR was merged at 860d9fb. Thanks a lot for contributing to OCA. ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Odoo 17, the Class
TourStepUtilswas removed, andstepUtilsis now anobjectinstead of aclass. When this module is installed, the tours stop working and throw the error:Uncaught Error: Dependencies should be defined by an array:This commit adapts the code to align with these changes, ensuring that tours work correctly.
V16
https://github.com/odoo/odoo/blob/b97f0cfbd6b39d176f9b7e465f6da0722222b010/addons/web_tour/static/src/js/tour_step_utils.js#L7
V17
https://github.com/odoo/odoo/blob/77243bc85db87fad2196052036390f65bd451eeb/addons/web_tour/static/src/tour_service/tour_utils.js#L426
@Tecnativa @CarlosRoca13 @pedrobaeza @yajo could you please review this, Thanks!