-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MIG] web_widget_open_tab: Migration to 18.0 #3029
Draft
amh-mw
wants to merge
25
commits into
OCA:18.0
Choose a base branch
from
amh-mw:18.0-mig-web_widget_open_tab
base: 18.0
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…inside other forms
Currently translated at 100.0% (6 of 6 strings) Translation: web-16.0/web-16.0-web_widget_open_tab Translate-URL: https://translation.odoo-community.org/projects/web-16-0/web-16-0-web_widget_open_tab/es/
The import mechanism in Odoo 18 does not seem to detect .esm.js files. ``` import { OpenTabWidget, openTabWidget } from "@web_widget_open_tab/js/open_tab_widget"; ``` yields ``` The following modules are needed by other modules but have not been defined, they may not be present in the correct asset bundle: @web_widget_open_tab/js/open_tab_widget ```
066cc1d
to
556a3cc
Compare
@yostashiro I noticed you commented on another MIG PR for this, so would you be willing to take a look at the unfortunate last commit I just pushed up? I had to set this to the side for a time and still don't have it working yet. |
@widadelbekkouri-odoo "Given enough eyeballs, all bugs are shallow"? |
@amh-mw Sorry, I don't have time to work on this at the moment. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.