Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[17.0][MIG] web_company_color: Migration to 17.0 #3025

Open
wants to merge 71 commits into
base: 17.0
Choose a base branch
from

Conversation

ArnauCForgeFlow
Copy link

@ArnauCForgeFlow ArnauCForgeFlow commented Dec 18, 2024

Standard migration to 17.0

supersedes #2813

Tardo and others added 30 commits December 17, 2024 09:42
Currently translated at 100.0% (9 of 9 strings)

Translation: web-12.0/web-12.0-web_company_color
Translate-URL: https://translation.odoo-community.org/projects/web-12-0/web-12-0-web_company_color/zh_CN/
Currently translated at 100.0% (9 of 9 strings)

Translation: web-12.0/web-12.0-web_company_color
Translate-URL: https://translation.odoo-community.org/projects/web-12-0/web-12-0-web_company_color/hr/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: web-13.0/web-13.0-web_company_color
Translate-URL: https://translation.odoo-community.org/projects/web-13-0/web-13-0-web_company_color/
Currently translated at 100.0% (9 of 9 strings)

Translation: web-13.0/web-13.0-web_company_color
Translate-URL: https://translation.odoo-community.org/projects/web-13-0/web-13-0-web_company_color/it/
Currently translated at 100.0% (9 of 9 strings)

Translation: web-13.0/web-13.0-web_company_color
Translate-URL: https://translation.odoo-community.org/projects/web-13-0/web-13-0-web_company_color/zh_CN/
Currently translated at 100.0% (9 of 9 strings)

Translation: web-13.0/web-13.0-web_company_color
Translate-URL: https://translation.odoo-community.org/projects/web-13-0/web-13-0-web_company_color/nl/
We need to disable the company unlinking test, as if not, when tested
in integrated environments, it fails as there are records linked to the
company, like the warehouse when `stock` module is installed.
Currently translated at 100.0% (12 of 12 strings)

Translation: web-14.0/web-14.0-web_company_color
Translate-URL: https://translation.odoo-community.org/projects/web-14-0/web-14-0-web_company_color/de/
Currently translated at 8.3% (1 of 12 strings)

Translation: web-14.0/web-14.0-web_company_color
Translate-URL: https://translation.odoo-community.org/projects/web-14-0/web-14-0-web_company_color/ca/
oca-ci and others added 27 commits December 17, 2024 09:42
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: web-16.0/web-16.0-web_company_color
Translate-URL: https://translation.odoo-community.org/projects/web-16-0/web-16-0-web_company_color/
Currently translated at 100.0% (10 of 10 strings)

Translation: web-16.0/web-16.0-web_company_color
Translate-URL: https://translation.odoo-community.org/projects/web-16-0/web-16-0-web_company_color/de/
Currently translated at 100.0% (10 of 10 strings)

Translation: web-16.0/web-16.0-web_company_color
Translate-URL: https://translation.odoo-community.org/projects/web-16-0/web-16-0-web_company_color/nl/
Currently translated at 100.0% (10 of 10 strings)

Translation: web-16.0/web-16.0-web_company_color
Translate-URL: https://translation.odoo-community.org/projects/web-16-0/web-16-0-web_company_color/es/
Before it didn't work if just a color was set because it couldn't find "color_navbar_bg_hover".
Moreover, in odoo enterprise the navbar background color only worked for the main app menu,
now it works for both main app menu and the navbar of the apps.
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: web-16.0/web-16.0-web_company_color
Translate-URL: https://translation.odoo-community.org/projects/web-16-0/web-16-0-web_company_color/
Currently translated at 100.0% (16 of 16 strings)

Translation: web-16.0/web-16.0-web_company_color
Translate-URL: https://translation.odoo-community.org/projects/web-16-0/web-16-0-web_company_color/fr/
Currently translated at 100.0% (16 of 16 strings)

Translation: web-16.0/web-16.0-web_company_color
Translate-URL: https://translation.odoo-community.org/projects/web-16-0/web-16-0-web_company_color/es/
Currently translated at 100.0% (16 of 16 strings)

Translation: web-16.0/web-16.0-web_company_color
Translate-URL: https://translation.odoo-community.org/projects/web-16-0/web-16-0-web_company_color/it/
Currently translated at 100.0% (16 of 16 strings)

Translation: web-16.0/web-16.0-web_company_color
Translate-URL: https://translation.odoo-community.org/projects/web-16-0/web-16-0-web_company_color/pt/
…ing the assetbundle

When trying to charge the assetbundle the theme-color("primary") function
is not found what causes problems when trying to set the default values.

With this changes the default value is the value set on https://github.com/odoo/odoo/blob/ad9f8fae717aae4cad5b3715c1f73ee906b64f8d/addons/web/static/src/scss/primary_variables.scss#L55
this change avoid the problems and the module works fine.

Addapted too the class for required fields.
Copy link
Contributor

@LoisRForgeFlow LoisRForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code and functional review 👍

Copy link
Contributor

@CarlosRoca13 CarlosRoca13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Navbar Background Color Hover option, seems to be not working... Can you review it?

@astirpe
Copy link
Member

astirpe commented Jan 3, 2025

@CarlosRoca13 did you notice that issue on Odoo Enterprise ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.