16.0 mig membership prorate variable period #168
Conversation
Currently translated at 100.0% (3 of 3 strings) Translation: vertical-association-12.0/vertical-association-12.0-membership_prorate_variable_period Translate-URL: https://translation.odoo-community.org/projects/vertical-association-12-0/vertical-association-12-0-membership_prorate_variable_period/pt_BR/
Currently translated at 100.0% (3 of 3 strings) Translation: vertical-association-12.0/vertical-association-12.0-membership_prorate_variable_period Translate-URL: https://translation.odoo-community.org/projects/vertical-association-12-0/vertical-association-12-0-membership_prorate_variable_period/it/
Currently translated at 100.0% (3 of 3 strings) Translation: vertical-association-14.0/vertical-association-14.0-membership_prorate_variable_period Translate-URL: https://translation.odoo-community.org/projects/vertical-association-14-0/vertical-association-14-0-membership_prorate_variable_period/ca/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: vertical-association-14.0/vertical-association-14.0-membership_prorate_variable_period Translate-URL: https://translation.odoo-community.org/projects/vertical-association-14-0/vertical-association-14-0-membership_prorate_variable_period/
Currently translated at 100.0% (6 of 6 strings) Translation: vertical-association-14.0/vertical-association-14.0-membership_prorate_variable_period Translate-URL: https://translation.odoo-community.org/projects/vertical-association-14-0/vertical-association-14-0-membership_prorate_variable_period/it/
|
@chienandalu wanna review this one? |
|
This PR has the |
|
Can you check it functionally @fcvalgar? Thanks! |
|
Hi @fcvalgar , I've reviewed the two day difference that you commented. It is kind of a bummer because it seems that is missing the first and the last day and it lead us to misunderstood of what the problem really is. I'll try to not enter too much in the details but this is a matter of decimal precision in the quantities. In your case you are prorrating for the last 236 days in the year. If the quantity of a year is 1, our prorrated quantity should be 0.646575(...) years but in the invoice line will store only 0.64 which is that value rounded to two decimals. That lead us to $24 difference. So a membership that cost $1 a day make us think that we are missing the starting and ending date but, sadly, not. To sum up, the difference that you notice is a precission error in the prorrate calculation. Because this is a migration I would consider that this PR is ok to merge but the roadmap will be updated to cover this issue later on. I have a couple of ideas of how make this run propelly but I feel that is out of the scope of this PR. Also, what do you think @EmilioPascual ? |
|
I think it's worth it to record your discoveries in the module's roadmap/known issues. |
|
Perhaps error is in the rounding in this line https://github.com/OCA/vertical-association/blob/16.0/membership_prorate/models/account_move_line.py#L37, but it's in another module. |
|
@rafaelbn this PR is ok to merge. We've all agreed on this migration to move on. Thank you! |
|
/ocabot migration membership_prorate_variable_period |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
|
@EmilioPascual @edlopen about this:
Please open an issue in githug and a subtas in our side. thank you! 😄 You are awesome! |
This comment was marked as resolved.
This comment was marked as resolved.
|
/ocabot merge patch |
|
Hey, thanks for contributing! Proceeding to merge this for you. |
|
Congratulations, your PR was merged at aacfeff. Thanks a lot for contributing to OCA. ❤️ |
Standard migration to 16.0
@moduon MT-1833
@yajo @EmilioPascual @Shide @rafaelbn review this PR when you can. Thank you!