[18.0][MIG] stock_location_tray: Migration to 18.0 #2257
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Extracted from stock_vertical_lift (OCA#633) Add tray types to stock locations, automatically generates sub-locations. Present them nicely with a custom widget.
Use the multi creation on records to create all the xmlids at once.
There is change in odoo/odoo for both 13.0 and 14.0 at odoo/odoo@b6ba603#diff-0b83f13eeb39606e0cc2ebe1443b40c01c19bf49ec16ab100dbcb0d0f4c9e4b6R99-R106. With the change, `UserError(_('You still have some product in locations %s')` is always risen before the two `ValidationError(_("Tray locations cannot be archived when they contain products.")` and `UserError(_("Trays cannot be modified when they contain products.")` of this module. Therefor, the OCA#987 changes tests to meet that flow change. To prove the dead code, we have two hacks: change context to bypass odoo/odoo checking as OCA@79fa705#diff-ce46c42b625b31fbfc9cd2646ccfe9d647a894001a331cd54d3ce0cf04b466a3R161-R163 and OCA@79fa705#diff-ce46c42b625b31fbfc9cd2646ccfe9d647a894001a331cd54d3ce0cf04b466a3R183-R187. We believe that in daily use, there is no hack like that.
…the stock.location.tray.type view
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
_get_idand_get_object_referencethat were one liner to_xmlid_lookupin commit odoo/odoo@15692f394.UserErrorin stock location in commit odoo/odoo@2b738dbe.Parsing error: 'import' and 'export' may appear only with 'sourceType: module'./static/js/to/static/js/backend/to match odoo convention (see an example in: https://github.com/odoo/odoo/tree/18.0/addons/web_editor/static/src/js/backend).show_source_locationandshow_destination_location) will never be passed through theaction_show_detailsfunction as before. This change fixes the issue that opens the replacement window we were talking about (video demonstration below), reflocation_idis now hidden from list view and replaced withstock quant, see: odoo/odoo@19f07f0show_source_locationandshow_destination_locationcalculation approach (instead of passing context via the outdated action).quant_idandlocation_dest_idfields.ROADMAP.mdseems to be fixed since the above commit (no more RPC call will not replace the current window).ROADMAP.mdmentioned) and it seems to have disappeared since version 17.0:version_14.0.webm
version_18.0.webm