-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[18.0][IMP] upgrade_analysis: don't depend on mako #3170
[18.0][IMP] upgrade_analysis: don't depend on mako #3170
Conversation
Hi @legalsylvain, @StefanRijnhart, |
7013055
to
9c39820
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice simplification. Thanks.
I guess you should remove mako here also, dont you think ?
9c39820
to
f25e8ec
Compare
thanks for the headsup! I'm juggling multiple changesets on upgrade_analysis here and missed that file |
f25e8ec
to
3cbc385
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for making me read up on special variables such as *_value
when using t-foreach
!
Merging as both module maintainers agree /ocabot merge patch |
This PR looks fantastic, let's merge it! |
Congratulations, your PR was merged at 0b90359. Thanks a lot for contributing to OCA. ❤️ |
given Odoo doesn't depend on mako any more and we have a perfectly fine templating engine built in, I propose to use that instead. The coverage file of the v18 migration has been created with this