[18.0][IMP] upgrade_analysis: don't depend on mako #3170
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @legalsylvain, @StefanRijnhart, |
hbrunn
force-pushed
the
18.0-upgrade_analysis-remove-mako
branch
from
7013055 to
9c39820
Compare
legalsylvain
approved these changes
Jan 20, 2025
hbrunn
force-pushed
the
18.0-upgrade_analysis-remove-mako
branch
from
9c39820 to
f25e8ec
Compare
|
thanks for the headsup! I'm juggling multiple changesets on upgrade_analysis here and missed that file |
hbrunn
force-pushed
the
18.0-upgrade_analysis-remove-mako
branch
from
f25e8ec to
3cbc385
Compare
StefanRijnhart
approved these changes
Jan 20, 2025
|
Merging as both module maintainers agree /ocabot merge patch |
|
This PR looks fantastic, let's merge it! |
|
Congratulations, your PR was merged at 0b90359. Thanks a lot for contributing to OCA. ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
given Odoo doesn't depend on mako any more and we have a perfectly fine templating engine built in, I propose to use that instead. The coverage file of the v18 migration has been created with this