Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[18.0][IMP] upgrade_analysis: don't depend on mako #3170

Merged
merged 1 commit into from
Jan 20, 2025

Conversation

hbrunn
Copy link
Member

@hbrunn hbrunn commented Jan 20, 2025

given Odoo doesn't depend on mako any more and we have a perfectly fine templating engine built in, I propose to use that instead. The coverage file of the v18 migration has been created with this

@OCA-git-bot
Copy link
Contributor

Hi @legalsylvain, @StefanRijnhart,
some modules you are maintaining are being modified, check this out!

@hbrunn hbrunn force-pushed the 18.0-upgrade_analysis-remove-mako branch from 7013055 to 9c39820 Compare January 20, 2025 06:07
Copy link
Contributor

@legalsylvain legalsylvain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice simplification. Thanks.

I guess you should remove mako here also, dont you think ?

https://github.com/hbrunn/server-tools/blob/18.0-upgrade_analysis-remove-mako/upgrade_analysis/__manifest__.py#L25

@hbrunn hbrunn force-pushed the 18.0-upgrade_analysis-remove-mako branch from 9c39820 to f25e8ec Compare January 20, 2025 06:56
@hbrunn
Copy link
Member Author

hbrunn commented Jan 20, 2025

thanks for the headsup! I'm juggling multiple changesets on upgrade_analysis here and missed that file

@hbrunn hbrunn force-pushed the 18.0-upgrade_analysis-remove-mako branch from f25e8ec to 3cbc385 Compare January 20, 2025 07:00
Copy link
Member

@StefanRijnhart StefanRijnhart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making me read up on special variables such as *_value when using t-foreach!

@StefanRijnhart
Copy link
Member

Merging as both module maintainers agree

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 18.0-ocabot-merge-pr-3170-by-StefanRijnhart-bump-patch, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 63d13a7 into OCA:18.0 Jan 20, 2025
6 of 7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 0b90359. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants