Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] base_multi_image: Attribute Error #3168

Merged
merged 1 commit into from
Jan 17, 2025
Merged

[FIX] base_multi_image: Attribute Error #3168

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 3 additions & 5 deletions base_multi_image/models/image.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,12 +88,10 @@
# Retrieve from remote url
self.image_1920 = self._get_image_from_url(self.load_from)
filename = self.load_from.split("/")[-1]
self.name, self.extension = os.path.splitext(filename)
self.name = os.path.splitext(filename)[0]

Check warning on line 91 in base_multi_image/models/image.py

View check run for this annotation

Codecov / codecov/patch

base_multi_image/models/image.py#L91 

Added line #L91 was not covered by tests
else:
self.image_1920 = self._get_image_from_file(self.load_from)
self.name, self.extension = os.path.splitext(
os.path.basename(self.load_from)
)
self.name = os.path.splitext(os.path.basename(self.load_from))[0]

Check warning on line 94 in base_multi_image/models/image.py

View check run for this annotation

Codecov / codecov/patch

base_multi_image/models/image.py#L94 

Added line #L94 was not covered by tests
self.name = self._make_name_pretty(self.name)
self.load_from = False

Expand Down Expand Up @@ -185,5 +183,5 @@
@api.onchange("filename")
def _onchange_filename(self):
if self.filename:
self.name, self.extension = os.path.splitext(self.filename)
self.name = os.path.splitext(self.filename)[0]

Check warning on line 186 in base_multi_image/models/image.py

View check run for this annotation

Codecov / codecov/patch

base_multi_image/models/image.py#L186 

Added line #L186 was not covered by tests
self.name = self._make_name_pretty(self.name)
Loading