Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[18.0][MIG] autovacuum_message_attachment: Migration to 18.0 #3158

Open
wants to merge 31 commits into
base: 18.0
Choose a base branch
from
Open

[18.0][MIG] autovacuum_message_attachment: Migration to 18.0 #3158

wants to merge 31 commits into from

Conversation

yankinmax
Copy link
Contributor

No description provided.

@yankinmax yankinmax mentioned this pull request Jan 8, 2025
Open
25 tasks
vvrossem
vvrossem reviewed Jan 16, 2025
View reviewed changes
Copy link

@vvrossem vvrossem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some suggestions 🙇

Please squash administrative commits too 🙏

autovacuum_message_attachment/models/autovacuum_mixin.py Show resolved Hide resolved
florian-dacosta and others added 27 commits January 21, 2025 15:26
@florian-dacosta @yankinmax
Migrate autovacuum_mail_message to version 12 and rename it
cdb36be
@florian-dacosta @yankinmax
Add possibility to delete attachments
b67d94d
@etobella @yankinmax
[REF] autovacuum_message_attachment: Improve the way we manage domains
419defa
@fmdl @yankinmax
[FIX] autovacuum_message_attachment : wrong message formating
5a70b91
@etobella @yankinmax
[FIX] autovacuum_message_attachment: The field name cannot be used as…
fa6b6bd 
… it is already present in other models
@etobella @yankinmax
[IMP] autovacuum_message_attachment: black, isort, prettier
6433063
@etobella @yankinmax
[MIG] autovacuum_message_attachment: Migration to 13.0
51071f8
@hkapatel-initos @yankinmax
[IMP] autovacuum_message_attachment: black, isort, prettier
19dc2ca
@hkapatel-initos @yankinmax
[MIG] autovacuum_message_attachment: Migration to 14.0
130ee6b
@extrememicro @yankinmax
Added translation using Weblate (Catalan)
1016fe8
@ibuioli @yankinmax
Added translation using Weblate (Spanish (Argentina))
3b7f4d8
@ibuioli @yankinmax
Translated using Weblate (Spanish (Argentina))
73f5704 
Currently translated at 100.0% (50 of 50 strings)

Translation: server-tools-14.0/server-tools-14.0-autovacuum_message_attachment
Translate-URL: https://translation.odoo-community.org/projects/server-tools-14-0/server-tools-14-0-autovacuum_message_attachment/es_AR/
@grindtildeath @yankinmax
Improve building of domain through osv.expression
c690961
@grindtildeath @yankinmax
Add selection of attachments through inheriting model
f031319 
Selection of attachments through inheriting model can be useful if
we want to purge attachments that are extended through another
model.

For example, shipping.label (from base_delivery_carrier_label)
inherits from ir.attachment but the attachment itself is linked to
the stock.picking model.
By using inheriting_model defined to shipping.label and setting
model_ids to stock.picking, we can safely select the attachments
linked to stock.pickings that are shipping labels and avoid deleting
any picking list or delivery note reports.
@ibuioli @yankinmax
Translated using Weblate (Spanish (Argentina))
f3e830b 
Currently translated at 100.0% (55 of 55 strings)

Translation: server-tools-14.0/server-tools-14.0-autovacuum_message_attachment
Translate-URL: https://translation.odoo-community.org/projects/server-tools-14-0/server-tools-14-0-autovacuum_message_attachment/es_AR/
@florian-dacosta @yankinmax
[MIG] autovacuum_message_attachment : migrate to v16
20971e6
@florian-dacosta @yankinmax
[UPD] autovacuum_message_attachment : add maintainer
c70b65a
@florian-dacosta @yankinmax
[IMP] Allow to delete attachment without res_model
a9c470f 
But allow it only if a file pattern is set, to avoid deleting all orphan attachments are some are auto-generated by Odoo
@yankinmax
[UPD] Update autovacuum_message_attachment.pot
8760509
@mymage @yankinmax
Added translation using Weblate (Italian)
abac659
@Ivorra78 @yankinmax
Added translation using Weblate (Spanish)
feffb3b
@Ivorra78 @yankinmax
Translated using Weblate (Spanish)
eb33484 
Currently translated at 67.3% (35 of 52 strings)

Translation: server-tools-16.0/server-tools-16.0-autovacuum_message_attachment
Translate-URL: https://translation.odoo-community.org/projects/server-tools-16-0/server-tools-16-0-autovacuum_message_attachment/es/
@Ivorra78 @yankinmax
Translated using Weblate (Spanish)
d06982c 
Currently translated at 100.0% (52 of 52 strings)

Translation: server-tools-16.0/server-tools-16.0-autovacuum_message_attachment
Translate-URL: https://translation.odoo-community.org/projects/server-tools-16-0/server-tools-16-0-autovacuum_message_attachment/es/
@mymage @yankinmax
Translated using Weblate (Italian)
9b4543d 
Currently translated at 100.0% (52 of 52 strings)

Translation: server-tools-16.0/server-tools-16.0-autovacuum_message_attachment
Translate-URL: https://translation.odoo-community.org/projects/server-tools-16-0/server-tools-16-0-autovacuum_message_attachment/it/
@florian-dacosta @yankinmax
[FIX] autovacuum_message_attachment : fix inheriting_model feature
263133d
@ibuioli @yankinmax
Translated using Weblate (Spanish (Argentina))
d66b12f 
Currently translated at 100.0% (52 of 52 strings)

Translation: server-tools-16.0/server-tools-16.0-autovacuum_message_attachment
Translate-URL: https://translation.odoo-community.org/projects/server-tools-16-0/server-tools-16-0-autovacuum_message_attachment/es_AR/
@mymage @yankinmax
Translated using Weblate (Italian)
af7fb70 
Currently translated at 100.0% (61 of 61 strings)

Translation: server-tools-16.0/server-tools-16.0-autovacuum_message_attachment
Translate-URL: https://translation.odoo-community.org/projects/server-tools-16-0/server-tools-16-0-autovacuum_message_attachment/it/
ibuioli and others added 3 commits January 21, 2025 15:28
@ibuioli @yankinmax
Translated using Weblate (Spanish (Argentina))
e37206d 
Currently translated at 100.0% (61 of 61 strings)

Translation: server-tools-16.0/server-tools-16.0-autovacuum_message_attachment
Translate-URL: https://translation.odoo-community.org/projects/server-tools-16-0/server-tools-16-0-autovacuum_message_attachment/es_AR/
@mymage @yankinmax
Translated using Weblate (Italian)
ad8e2ff 
Currently translated at 100.0% (61 of 61 strings)

Translation: server-tools-16.0/server-tools-16.0-autovacuum_message_attachment
Translate-URL: https://translation.odoo-community.org/projects/server-tools-16-0/server-tools-16-0-autovacuum_message_attachment/it/
@yankinmax
[IMP] autovacuum_message_attachment: pre-commit auto fixes
8651a4a
@yankinmax yankinmax force-pushed the 18.0-mig-autovacuum_message_attachment branch from 213e6c8 to af7967b Compare January 21, 2025 13:28
StephaneMangin
StephaneMangin approved these changes Jan 21, 2025
View reviewed changes
Copy link
Contributor

@StephaneMangin StephaneMangin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe it could be a good approach to increase tests when the coverage increase over time. It's less effort on the long term. But anyway LGTM

autovacuum_message_attachment/models/vacuum_rule.py Show resolved Hide resolved
@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@yankinmax yankinmax force-pushed the 18.0-mig-autovacuum_message_attachment branch from af7967b to 79ce63a Compare January 21, 2025 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ricardoalso Ricardoalso Ricardoalso approved these changes

@vvrossem vvrossem vvrossem approved these changes

@StephaneMangin StephaneMangin StephaneMangin approved these changes

Assignees
No one assigned
Labels
approved ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.