Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[17.0][ADD] procurement_purchase_requisition_generation: New module #2568

Merged
merged 1 commit into from
Feb 20, 2025
Merged

[17.0][ADD] procurement_purchase_requisition_generation: New module #2568

merged 1 commit into from
Feb 20, 2025

Conversation

victoralmau
Copy link
Member

@victoralmau victoralmau commented Feb 17, 2025 •
edited
Loading

New module

Please @pedrobaeza can you review it?

@Tecnativa TT54940

@pedrobaeza pedrobaeza added this to the 17.0 milestone Feb 17, 2025
@victoralmau victoralmau force-pushed the 17.0-add-procurement_purchase_requisition_generation branch from f203d57 to 60dd38b Compare February 17, 2025 16:24
@victoralmau victoralmau force-pushed the 17.0-add-procurement_purchase_requisition_generation branch from 60dd38b to 8cbdc29 Compare February 18, 2025 08:08
carlos-lopez-tecnativa
carlos-lopez-tecnativa suggested changes Feb 19, 2025
View reviewed changes
Copy link

@carlos-lopez-tecnativa carlos-lopez-tecnativa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested functionally.

I have a question related to dropshipping.

Is linking the sale order with the purchase order generated from a requisition out of scope for this module?

I'm just thinking out loud to avoid needing a glue module like
https://github.com/odoo/odoo/tree/15.0/addons/purchase_requisition_stock_dropshipping

Procurement=Create a draft purchase order
image

Procurement=Propose a call for tenders. (No picking related to the sale order)
image

@victoralmau victoralmau force-pushed the 17.0-add-procurement_purchase_requisition_generation branch 2 times, most recently from dc7371e to d5b68a7 Compare February 20, 2025 12:51
@victoralmau
Copy link
Member Author

Reviewing the dropshipping use case I confirm that an extension for sales would be necessary to take into account this casuistry: create the sale_line_id field in purchase.requisition.line and set it when it is created from a sale.order + transfer that value (sale_line_id) to the purchase order line that would be generated.

@victoralmau victoralmau force-pushed the 17.0-add-procurement_purchase_requisition_generation branch from d5b68a7 to a386ac5 Compare February 20, 2025 15:43
carlos-lopez-tecnativa
carlos-lopez-tecnativa approved these changes Feb 20, 2025
View reviewed changes
Copy link

@carlos-lopez-tecnativa carlos-lopez-tecnativa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pedrobaeza
Copy link
Member

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 17.0-ocabot-merge-pr-2568-by-pedrobaeza-bump-nobump, awaiting test results.

@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 3e36e7b. Thanks a lot for contributing to OCA. ❤️

@OCA-git-bot OCA-git-bot merged commit 6585567 into OCA:17.0 Feb 20, 2025
9 checks passed
@pedrobaeza pedrobaeza deleted the 17.0-add-procurement_purchase_requisition_generation branch February 20, 2025 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pedrobaeza pedrobaeza pedrobaeza approved these changes

@carlos-lopez-tecnativa carlos-lopez-tecnativa carlos-lopez-tecnativa approved these changes

Assignees
No one assigned
Labels
approved merged 🎉
Projects
None yet
Milestone
17.0
Development

Successfully merging this pull request may close these issues.
4 participants
@victoralmau @pedrobaeza @OCA-git-bot @carlos-lopez-tecnativa