-
-
Notifications
You must be signed in to change notification settings - Fork 605
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[16.0][ADD] pos_cash_control_override: New module #1270
[16.0][ADD] pos_cash_control_override: New module #1270
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code review
Is it possible to create some tests to avoid problems in the future?
I'm going to check if I can import a tour from the core module |
874b841
to
f931a43
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great!
Code review
2558c16
to
8c449c0
Compare
8c449c0
to
a1560ad
Compare
Did you check with just this module loaded? |
No, do not uninstall anything in runboat. All modules were installed. If it is necessary to test it alone then I will do the local tests. |
As for othe modules in this repo I can't be my life on them behaving friendly with this feature 😅 but it stands for itself |
You can try in runboat in the base database and installing it alone. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
/ocabot merge nobump |
On my way to merge this fine PR! |
Congratulations, your PR was merged at cc6f47d. Thanks a lot for contributing to OCA. ❤️ |
From this change a Point of Sale user who needs to perform cash control operations Accounting/Billing permission is required. That's a huge permission for the kind of user that only does cashing machine operations.
We're recovering the former behavior present in previous versions.
This module will be unnecessary if odoo/odoo#188798 gets merged or the former permissions paradigm is restored in any other way.
cc @Tecnativa TT51987
please review @pedrobaeza @pilarvargas-tecnativa