Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[16.0][ADD] pos_cash_control_override: New module #1270

Merged
merged 1 commit into from
Dec 4, 2024

Conversation

chienandalu
Copy link
Member

From this change a Point of Sale user who needs to perform cash control operations Accounting/Billing permission is required. That's a huge permission for the kind of user that only does cashing machine operations.

We're recovering the former behavior present in previous versions.

This module will be unnecessary if odoo/odoo#188798 gets merged or the former permissions paradigm is restored in any other way.

cc @Tecnativa TT51987

please review @pedrobaeza @pilarvargas-tecnativa

@pedrobaeza pedrobaeza added this to the 16.0 milestone Nov 27, 2024
Copy link
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review

Is it possible to create some tests to avoid problems in the future?

@chienandalu
Copy link
Member Author

I'm going to check if I can import a tour from the core module

@chienandalu chienandalu force-pushed the 16.0-add-pos_cash_control_override branch from 874b841 to f931a43 Compare November 27, 2024 15:21
Copy link
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

Code review

@chienandalu chienandalu force-pushed the 16.0-add-pos_cash_control_override branch 2 times, most recently from 2558c16 to 8c449c0 Compare November 28, 2024 08:54
@chienandalu chienandalu force-pushed the 16.0-add-pos_cash_control_override branch from 8c449c0 to a1560ad Compare November 28, 2024 08:55
@pilarvargas-tecnativa
Copy link

Testing in runboat, if I access with the Demo user without billing permissions but with the pos user permission, when accessing pos, it does not load anything. I don't know if it's a runboat issue.

image
image

@chienandalu
Copy link
Member Author

I don't know if it's a runboat issue.

Did you check with just this module loaded?

@pilarvargas-tecnativa
Copy link

Did you check with just this module loaded?

No, do not uninstall anything in runboat. All modules were installed. If it is necessary to test it alone then I will do the local tests.

@chienandalu
Copy link
Member Author

As for othe modules in this repo I can't be my life on them behaving friendly with this feature 😅 but it stands for itself

@pedrobaeza
Copy link
Member

You can try in runboat in the base database and installing it alone.

Copy link

@pilarvargas-tecnativa pilarvargas-tecnativa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@pedrobaeza
Copy link
Member

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 16.0-ocabot-merge-pr-1270-by-pedrobaeza-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit a66bcc2 into OCA:16.0 Dec 4, 2024
5 of 7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at cc6f47d. Thanks a lot for contributing to OCA. ❤️

@pedrobaeza pedrobaeza deleted the 16.0-add-pos_cash_control_override branch December 4, 2024 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants