-
-
Notifications
You must be signed in to change notification settings - Fork 876
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[17.0][MIG] partner_subject_to_vat: Migration to 17.0 #2019
base: 17.0
Are you sure you want to change the base?
[17.0][MIG] partner_subject_to_vat: Migration to 17.0 #2019
Conversation
Currently translated at 100.0% (2 of 2 strings) Translation: partner-contact-16.0/partner-contact-16.0-partner_subject_to_vat Translate-URL: https://translation.odoo-community.org/projects/partner-contact-16-0/partner-contact-16-0-partner_subject_to_vat/it/
|
||
{ | ||
"name": "Partner Subject to VAT", | ||
"summary": """ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should go on one line. And in a simple pair of double quotes, instead of triple.
@@ -0,0 +1,13 @@ | |||
<?xml version="1.0" encoding="utf-8" ?> | |||
<odoo> | |||
<record model="ir.ui.view" id="view_partner_form_industry"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
New id, should be the same as the old. You can put the module name in the name to easily differentiate in list of views (like <field name="name">view_partner_form - partner_subject_to_vat</field>
).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still need to rename the id to view_partner_form, to make it the same as the inherited id.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please Review.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Thanks for your contribution. Small changes and we are good to go.
58b8163
to
5d2e946
Compare
@NL66278, Thanks for the suggestions!Please Review.it's done. |
5d2e946
to
56b60dd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 LGTM, Thank you for your contribution.
No description provided.