Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[17.0][MIG] partner_subject_to_vat: Migration to 17.0 #2019

Open
wants to merge 7 commits into
base: 17.0
Choose a base branch
from

Conversation

BhaveshHeliconia
Copy link

No description provided.

@BhaveshHeliconia BhaveshHeliconia mentioned this pull request Feb 27, 2025
68 tasks

{
"name": "Partner Subject to VAT",
"summary": """
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should go on one line. And in a simple pair of double quotes, instead of triple.

@@ -0,0 +1,13 @@
<?xml version="1.0" encoding="utf-8" ?>
<odoo>
<record model="ir.ui.view" id="view_partner_form_industry">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New id, should be the same as the old. You can put the module name in the name to easily differentiate in list of views (like <field name="name">view_partner_form - partner_subject_to_vat</field>).

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still need to rename the id to view_partner_form, to make it the same as the inherited id.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please Review.

Copy link
Contributor

@NL66278 NL66278 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Thanks for your contribution. Small changes and we are good to go.

@BhaveshHeliconia BhaveshHeliconia force-pushed the 17.0-mig-partner_subject_to_vat branch from 58b8163 to 5d2e946 Compare March 13, 2025 11:44
@BhaveshHeliconia
Copy link
Author

@NL66278, Thanks for the suggestions!Please Review.it's done.

@BhaveshHeliconia BhaveshHeliconia force-pushed the 17.0-mig-partner_subject_to_vat branch from 5d2e946 to 56b60dd Compare March 17, 2025 05:49
Copy link
Contributor

@NL66278 NL66278 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM, Thank you for your contribution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants