[17.0][MIG] partner_employee_quantity: Migration to 17.0 #1950
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
68 tasks
carlos-lopez-tecnativa
suggested changes
Jan 7, 2025
chienandalu
suggested changes
Jan 7, 2025
| @@ -10,7 +10,7 @@ | |||
| <group | |||
| name="employee_quantity" | |||
| string="Employee quantity" | |||
| attrs="{'invisible': [('is_company', '=', False)]}" | |||
| invisible="is_company == False" | |||
There was a problem hiding this comment.
Better use truthy / falsey coercion. If by any chance is_company is None this won't be true, so better be safe to avoid bugs that later ar really hard to find out 😉
Suggested change
| invisible="is_company == False" | |
| invisible="not is_company" |
There was a problem hiding this comment.
When you have a moment, could you check if I did it correctly? Thanks again!
juancarlosonate-tecnativa
force-pushed
the
17.0-mig-partner_employee_quantity
branch
from
28eed5e to
68a48b7
Compare
Currently translated at 100.0% (16 of 16 strings) Translation: partner-contact-8.0/partner-contact-8.0-partner_employee_quantity Translate-URL: https://translation.odoo-community.org/projects/partner-contact-8-0/partner-contact-8-0-partner_employee_quantity/es/
Currently translated at 43.7% (7 of 16 strings) Translation: partner-contact-8.0/partner-contact-8.0-partner_employee_quantity Translate-URL: https://translation.odoo-community.org/projects/partner-contact-8-0/partner-contact-8-0-partner_employee_quantity/it/
* Standard procedure * Adapt dependencies * Adapt menu * Improve view layout * README by fragments * Rise to mature status with maintainer myself
Currently translated at 53.3% (8 of 15 strings) Translation: partner-contact-15.0/partner-contact-15.0-partner_employee_quantity Translate-URL: https://translation.odoo-community.org/projects/partner-contact-15-0/partner-contact-15-0-partner_employee_quantity/it/
Currently translated at 93.3% (14 of 15 strings) Translation: partner-contact-15.0/partner-contact-15.0-partner_employee_quantity Translate-URL: https://translation.odoo-community.org/projects/partner-contact-15-0/partner-contact-15-0-partner_employee_quantity/sl/
Currently translated at 100.0% (15 of 15 strings) Translation: partner-contact-16.0/partner-contact-16.0-partner_employee_quantity Translate-URL: https://translation.odoo-community.org/projects/partner-contact-16-0/partner-contact-16-0-partner_employee_quantity/it/
juancarlosonate-tecnativa
force-pushed
the
17.0-mig-partner_employee_quantity
branch
from
68a48b7 to
f9cbdba
Compare
chienandalu
approved these changes
Mar 5, 2025
carlos-lopez-tecnativa
approved these changes
Mar 5, 2025
|
This PR has the |
marcelsavegnago
approved these changes
Mar 5, 2025
|
/ocabot migration partner_employee_quantity |
|
Hey, thanks for contributing! Proceeding to merge this for you. |
|
Congratulations, your PR was merged at eb1c95e. Thanks a lot for contributing to OCA. ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migration to 17.0
TT52340
@Tecnativa @chienandalu @carlos-lopez-tecnativa Could you please review this migration and let me know if everything looks correct? Thx!