Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[17.0][MIG] partner_company_default #1876

Merged
merged 9 commits into from
Oct 25, 2024
Merged

[17.0][MIG] partner_company_default #1876

merged 9 commits into from
Oct 25, 2024

Conversation

giarve
Copy link

@giarve giarve commented Oct 19, 2024

Improvement over #1759 as it has all fixes

@pedrobaeza pedrobaeza mentioned this pull request Oct 19, 2024
Closed
@pedrobaeza pedrobaeza added this to the 17.0 milestone Oct 19, 2024
@pedrobaeza
Copy link
Member

/ocabot migration partner_company_default

@OCA-git-bot OCA-git-bot mentioned this pull request Oct 19, 2024
Open
65 tasks
@rousseldenis
Copy link
Contributor

@giarve Thanks for this. But you need to take the whole commit history following the migration procedure: https://github.com/OCA/maintainer-tools/wiki/Migration-to-version-17.0#technical-method-to-migrate-a-module-from-160-to-170-branch

@giarve giarve force-pushed the 17.0-mig-partner_company_default branch from cb61b08 to 6cebb27 Compare October 22, 2024 19:44
@giarve
Copy link
Author

giarve commented Oct 22, 2024

@giarve Thanks for this. But you need to take the whole commit history following the migration procedure: https://github.com/OCA/maintainer-tools/wiki/Migration-to-version-17.0#technical-method-to-migrate-a-module-from-160-to-170-branch

Thanks for pointing out. I shallow cloned, and the commit was not included in the rebase. Fixed.

yostashiro
yostashiro approved these changes Oct 22, 2024
View reviewed changes
Copy link
Member

@yostashiro yostashiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the migration!

partner_company_default/readme/DESCRIPTION.md Outdated Show resolved Hide resolved
@giarve giarve force-pushed the 17.0-mig-partner_company_default branch from 6cebb27 to adbf455 Compare October 25, 2024 10:29
@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

1 similar comment
@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@rousseldenis
Copy link
Contributor

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 17.0-ocabot-merge-pr-1876-by-rousseldenis-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit debdedf into OCA:17.0 Oct 25, 2024
7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at f56a815. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rousseldenis rousseldenis rousseldenis approved these changes

@yostashiro yostashiro yostashiro approved these changes

Assignees
No one assigned
Labels
approved merged 🎉 migration needs review ready to merge
Projects
None yet
Milestone
17.0
Development

Successfully merging this pull request may close these issues.
9 participants
@giarve @pedrobaeza @rousseldenis @OCA-git-bot @yostashiro @AungKoKoLin1997 @rinaldifirdaus @mymage @ivantodorovich