Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[17.0][MIG] partner_contact_access_link: Migration to 17.0 #1649

Closed
wants to merge 22 commits into from
Closed

[17.0][MIG] partner_contact_access_link: Migration to 17.0 #1649

wants to merge 22 commits into from

Conversation

rov-adhoc
Copy link

No description provided.

jjscarafia
jjscarafia approved these changes Jan 26, 2024
View reviewed changes
Copy link
Contributor

@jjscarafia jjscarafia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pedrobaeza
Copy link
Member

/ocabot migration partner_contact_access_link

@OCA-git-bot OCA-git-bot added this to the 17.0 milestone Jan 27, 2024
@OCA-git-bot OCA-git-bot mentioned this pull request Jan 27, 2024
Open
65 tasks
CRogos
CRogos reviewed Mar 28, 2024
View reviewed changes
Copy link

@CRogos CRogos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you cleanup the commit history according to:
https://github.com/OCA/maintainer-tools/wiki/Merge-commits-in-pull-requests#mergesquash-the-commits-generated-by-bots-or-weblate

This would also trigger the rebuild because the runboat database is not available anymore, so I could not test.

LGTM so far

Jairo Llopis and others added 13 commits April 3, 2024 10:02
@rov-adhoc
[ADD] partner_contact_access_link: reach contact full form
ed2d5b8 
This module extends the functionality of the partners form
and to allow you to click on a button and open the full contact form
while watching a company form.

@Tecnativa TT24492 TT24498
@oca-travis @rov-adhoc
[UPD] Update partner_contact_access_link.pot
953caba
@HaraldPanten @rov-adhoc
[IMP] partner_contact_access_link: black, isort, prettier
edb48fa
@HaraldPanten @rov-adhoc
[MIG]partner_contact_access_link: Migration to 13.0
fce2584
@oca-travis @rov-adhoc
[UPD] Update partner_contact_access_link.pot
bbc6b8c
@OCA-git-bot @rov-adhoc
[UPD] README.rst
01c5466
@newtratip @rov-adhoc
[MIG] partner_contact_access_link: Migration to 14.0
64d7afd
@oca-travis @rov-adhoc
[UPD] Update partner_contact_access_link.pot
939cefd
@emagdalenaC2i @rov-adhoc
[MIG] partner_contact_access_link : Migration to 15.0
4103adb
@rov-adhoc
[UPD] Update partner_contact_access_link.pot
0df31ef
@OCA-git-bot @rov-adhoc
[UPD] README.rst
c29b307
@juliap98 @rov-adhoc
Added translation using Weblate (Catalan)
c1136f3
@juliap98 @rov-adhoc
Translated using Weblate (Catalan)
01074e1 
Currently translated at 100.0% (2 of 2 strings)

Translation: partner-contact-15.0/partner-contact-15.0-partner_contact_access_link
Translate-URL: https://translation.odoo-community.org/projects/partner-contact-15-0/partner-contact-15-0-partner_contact_access_link/ca/
@rov-adhoc rov-adhoc force-pushed the 17.0-mig-partner_contact_access_link branch from 7cf49e1 to a0c17e5 Compare April 3, 2024 13:05
@rov-adhoc
Copy link
Author

@CRogos Hey! Please let me know if now its ok.
Best regards

CRogos
CRogos reviewed Apr 3, 2024
View reviewed changes
Copy link

@CRogos CRogos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The module is working fine, but it looks like some of the pre-commit changes are now in the translation commit.

And also the yellow commits should be merged into the commit above.

image

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

CRogos
CRogos suggested changes Apr 22, 2024
View reviewed changes
Copy link

@CRogos CRogos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rov-adhoc are you still working on this?

@rov-adhoc rov-adhoc force-pushed the 17.0-mig-partner_contact_access_link branch from a0c17e5 to a077ea9 Compare April 27, 2024 14:06
@rov-adhoc rov-adhoc force-pushed the 17.0-mig-partner_contact_access_link branch from a077ea9 to ec19bba Compare April 27, 2024 14:08
@rov-adhoc rov-adhoc force-pushed the 17.0-mig-partner_contact_access_link branch from ec19bba to f6b8cac Compare April 27, 2024 14:29
@rov-adhoc
Copy link
Author

@CRogos Hey! I have just made the modification. Please let me know if it looks okay now.

Thanks in advance!

@CRogos
Copy link

CRogos commented Apr 29, 2024

@rov-adhoc unfortunate not.
The changes which should be in the "[IMP] partner_contact_access_link: pre-commit auto fixes" commit are in the commit above.

image

And also the oca-* commits are not squashed.
image

@CRogos
Copy link

CRogos commented May 15, 2024

@rov-adhoc are you still working on this?

@HaraldPanten
Copy link
Contributor

HaraldPanten commented May 15, 2024 •
edited
Loading

@CRogos We'll open a new migration PR to manage this. Leave us it in our hands 👍

@pedrobaeza
Copy link
Member

Superseded by #1758

@pedrobaeza pedrobaeza closed this May 17, 2024
@Tisho99 Tisho99 mentioned this pull request May 17, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CRogos CRogos CRogos requested changes

@igallart igallart igallart approved these changes

@jjscarafia jjscarafia jjscarafia approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
17.0
Development

Successfully merging this pull request may close these issues.