-
-
Notifications
You must be signed in to change notification settings - Fork 852
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[REF] partner_second_lastname: clean firstname and lastname2 when partner is a company #1466
[REF] partner_second_lastname: clean firstname and lastname2 when partner is a company #1466
Conversation
ad19971
to
979e7f3
Compare
@JordiBForgeFlow @hugho-ad @luistorresm @antespi Could you review it, please? |
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. |
/ocabot merge major |
What a great day to merge this nice PR. Let's do it! |
@moylop260 your merge command was aborted due to failed check(s), which you can inspect on this commit of 14.0-ocabot-merge-pr-1466-by-moylop260-bump-major. After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red. |
…tner is a company When you create a partner type individual and update to company, the field `lastname` is filled-out with the full name but the fields `firstname` and lastname2 are not cleaned, it's causing when you update the partner name with a different order, the full name is computed based on the fields `firstname`, `lastname` and lastname2 and it's inconsistent. This commit is cleaning the fields `firstname` and `lastname2` from the write method.
979e7f3
to
85587cb
Compare
FYI The CI is failing because an error not-related, issue related: #1557 |
Hi @sbidoul Could be it merged manually? |
Yes, everything works after a manual merge. The wheel will be published overnight. |
When you create a partner type individual and update to company, the field
lastname
is filled-out with the full name but the fieldsfirstname
and lastname2 are not cleaned,it's causing when you update the partner name with a different order, the full name is computed based on the
fields
firstname
,lastname
and lastname2 and it's inconsistent.This commit is cleaning the fields
firstname
andlastname2
from the write method.Fix #1465