Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REF] partner_second_lastname: clean firstname and lastname2 when partner is a company #1466

Conversation

fernandahf
Copy link

When you create a partner type individual and update to company, the field lastname is filled-out with the full name but the fields firstname and lastname2 are not cleaned,
it's causing when you update the partner name with a different order, the full name is computed based on the
fields firstname, lastname and lastname2 and it's inconsistent.

This commit is cleaning the fields firstname and lastname2 from the write method.

Fix #1465

@fernandahf fernandahf force-pushed the 14.0-fix-clean-fields-when-partner-company-fer branch 4 times, most recently from ad19971 to 979e7f3 Compare February 8, 2023 19:08
@moylop260
Copy link

@JordiBForgeFlow @hugho-ad @luistorresm @antespi

Could you review it, please?

@github-actions
Copy link

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Jun 18, 2023
@moylop260
Copy link

/ocabot merge major

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 14.0-ocabot-merge-pr-1466-by-moylop260-bump-major, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Jun 19, 2023
Signed-off-by moylop260
@OCA-git-bot
Copy link
Contributor

@moylop260 your merge command was aborted due to failed check(s), which you can inspect on this commit of 14.0-ocabot-merge-pr-1466-by-moylop260-bump-major.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

@github-actions github-actions bot removed the stale PR/Issue without recent activity, it'll be soon closed automatically. label Jul 9, 2023
…tner is a company

When you create a partner type individual and update to company,
the field `lastname` is filled-out with the full name but the fields
`firstname` and lastname2 are not cleaned,
it's causing when you update the partner name with a different order,
the full name is computed based on the
fields `firstname`, `lastname` and lastname2 and it's inconsistent.

This commit is cleaning the fields `firstname` and `lastname2` from the
write method.
@fernandahf fernandahf force-pushed the 14.0-fix-clean-fields-when-partner-company-fer branch from 979e7f3 to 85587cb Compare August 2, 2023 23:19
@fernandahf
Copy link
Author

FYI

The CI is failing because an error not-related, issue related: #1557

@moylop260
Copy link

Hi @sbidoul

Could be it merged manually?

@sbidoul
Copy link
Member

sbidoul commented Aug 3, 2023

Yes, everything works after a manual merge. The wheel will be published overnight.

@moylop260 moylop260 merged commit 84f9389 into OCA:14.0 Aug 3, 2023
2 of 4 checks passed
@moylop260 moylop260 deleted the 14.0-fix-clean-fields-when-partner-company-fer branch August 3, 2023 23:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants