[16.0][IMP] add template seq widget

.pre-commit-config.yaml

@@ -93,7 +93,7 @@ repos:
           - --color
           - --fix
   - repo: https://github.com/pre-commit/pre-commit-hooks
-    rev: v4.3.0
+    rev: v5.0.0
     hooks:
       - id: trailing-whitespace
         # exclude autogenerated files

fleet_vehicle_inspection/models/fleet_vehicle_inspection_line.py

@@ -41,7 +41,7 @@ class FleetVehicleInspectionLine(models.Model):
         copy=False,
     )
     result_description = fields.Char()
-    sequence = fields.Integer(string="Sequence", default=10)
+    sequence = fields.Integer(default=10)
     state = fields.Selection(
         related="inspection_id.state",
         readonly=True,

fleet_vehicle_inspection_template/models/fleet_vehicle_inspection.py

@@ -15,6 +15,7 @@ class FleetVehicleInspection(models.Model):
     def _compute_line_data_for_template_change(self, line):
         return {
             "inspection_item_id": line.inspection_template_item_id.id,
+            "sequence": line.sequence,
             "state": "draft",
         }
 
@@ -25,7 +26,11 @@ def _onchange_inspection_template_id(self):
             self.note = self.inspection_template_id.note
 
             inspection_lines = [(5, 0, 0)]
-            for line in self.inspection_template_id.inspection_template_line_ids:
+            # Sort the lines by sequence before appending
+            for line in sorted(
+                self.inspection_template_id.inspection_template_line_ids,
+                key=lambda linei: linei.sequence,
+            ):
                 data = self._compute_line_data_for_template_change(line)
                 inspection_lines.append((0, 0, data))
 

fleet_vehicle_inspection_template/models/fleet_vehicle_inspection_template_line.py

@@ -24,3 +24,5 @@ class FleetVehicleInspectionTemplateLine(models.Model):
         required=True,
         copy=True,
     )
+
+    sequence = fields.Integer(default=10)

fleet_vehicle_inspection_template/tests/test_fleet_vehicle_inspection_template.py

@@ -17,9 +17,9 @@ def setUpClass(cls):
 
         cls.item_02 = cls.inspection_item.create({"name": "Mirrors"})
 
-        cls.inspection_template = cls.inspection_template.create(
+        cls.inspection_template_01 = cls.inspection_template.create(
             {
-                "name": "TemplateTest",
+                "name": "TemplateTest_01",
                 "inspection_template_line_ids": [
                     (
                         0,
@@ -35,15 +35,69 @@ def setUpClass(cls):
             }
         )
 
+        cls.inspection_template_02 = cls.inspection_template.create(
+            {
+                "name": "TemplateTest_02",
+                "inspection_template_line_ids": [
+                    (
+                        0,
+                        0,
+                        {
+                            "inspection_template_item_id": cls.item_01.id,
+                            "sequence": 11,  # Different sequence in the template line
+                        },
+                    ),
+                    (
+                        0,
+                        0,
+                        {
+                            "inspection_template_item_id": cls.item_02.id,
+                            "sequence": 10,  # Different sequence in the template line
+                        },
+                    ),
+                ],
+            }
+        )
+
         cls.inspection = cls.inspection.create(
             {
                 "vehicle_id": cls.vehicle,
-                "inspection_template_id": cls.inspection_template.id,
+                "inspection_template_id": cls.inspection_template_01.id,
             }
         )
 
     def test_fleet_vehicle_inspection(self):
+        # --- Test with an inspection template ---
+        self.inspection._onchange_inspection_template_id()
+
+        self.assertEqual(self.inspection.name, self.inspection_template_01.name)
+        self.assertTrue(self.inspection.inspection_line_ids)
 
+        # --- Change the template ID ---
+        self.inspection.inspection_template_id = self.inspection_template_02
+
+        # Trigger the onchange method again
         self.inspection._onchange_inspection_template_id()
-        self.assertEqual(self.inspection.name, self.inspection_template.name)
+
+        self.assertEqual(len(self.inspection.inspection_line_ids), 2)
+
+        # Check if the sequence is correctly copied from the template line
+        line_1 = self.inspection.inspection_line_ids.filtered(
+            lambda linei: linei.inspection_item_id == self.item_01
+        )
+        self.assertEqual(line_1.sequence, 11)
+
+        # --- Test without an inspection template ---
+        self.inspection.inspection_template_id = False  # Remove the template
+
+        # Trigger the onchange method again
+        self.inspection._onchange_inspection_template_id()
+
+        # Assert that the name and note are not changed
+        self.assertEqual(self.inspection.name, self.inspection_template_02.name)
+        # (remains the same as the previous template)
+        self.assertNotEqual(self.inspection.name, self.inspection_template_01.name)
+
+        # Assert that the inspection lines are NOT removed
         self.assertTrue(self.inspection.inspection_line_ids)
+        self.assertEqual(len(self.inspection.inspection_line_ids), 2)

fleet_vehicle_inspection_template/views/fleet_vehicle_inspection_template.xml

@@ -27,6 +27,7 @@
                         >
                             <field name="inspection_template_line_ids">
                                 <tree editable="bottom">
+                                    <field name="sequence" widget="handle" />
                                     <field
                                         name="inspection_template_item_id"
                                         string="Inspection Template Line"