Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[17.0][MIG] account_ecotax_sale: Migration to 17.0 #481

Open
wants to merge 13 commits into
base: 17.0
Choose a base branch
from
Open

[17.0][MIG] account_ecotax_sale: Migration to 17.0 #481

wants to merge 13 commits into from

Conversation

mourad-ehm
Copy link

No description provided.

@mourad-ehm
Copy link
Author

@florian-dacosta

vvrossem
vvrossem approved these changes Jan 29, 2025
View reviewed changes
Copy link

@vvrossem vvrossem left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
pre-approving: module version needs to be corrected

@mourad-ehm
Copy link
Author

Hi @vvrossem, Thanks for review. I accepted your commit suggestions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SilvioC2C SilvioC2C SilvioC2C left review comments

@vvrossem vvrossem vvrossem approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mourad-ehm @vvrossem @SilvioC2C @bealdav @florian-dacosta