-
-
Notifications
You must be signed in to change notification settings - Fork 777
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[16.0][FIX] account_move_line_purchase_info: do not consider stock entry lines on revaluations #2018
base: 16.0
Are you sure you want to change the base?
[16.0][FIX] account_move_line_purchase_info: do not consider stock entry lines on revaluations #2018
Conversation
2d9cdfe
to
c98562c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code review LG. I am not sure if we can have a Many2one field with a suffix that is not "_id". It's true purchase_line_id_oca_id sounds weird :S
@AaronHForgeFlow I agree, maybe it could be oca_purchase_line_id? |
account_move_line_purchase_info/migrations/16.0.2.0.0/post-migration.py
Outdated
Show resolved
Hide resolved
Yes, I prefer this one. |
…try lines on revaluations Up to now, stock entries were considered in the revaluation process as they were stored on field invoice_lines. To avoid that we introduced a dedicated field to manage stock entries and avoid taking them into account in the revaluation odoo core process.
c98562c
to
6e431b4
Compare
@AaronHForgeFlow @JordiMForgeFlow Thanks for your suggestions, I applied changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Functional review, including the revaluation case, it works good.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would like to get more people involved in this review, but LGTM
CC @OCA/accounting-maintainers
This PR has the |
Issue: #2017
Up to now, stock entries were considered in the revaluation process as they were stored on field invoice_lines. To avoid that we introduced a dedicated field to manage stock entries and avoid taking them into account in the revaluation odoo core process.