🐛 fix: saturating audio + icon not loading#3
Merged
Conversation
- setPixelFormat → setOption(sample_fmt, s16) for audio (was using video option) - Replace broken MASTER_GAIN hardware control with digital gain (hardware is unreliable on PulseAudio/PipeWire) - Fix sign-extension bug in digital volume gain loop (and 0xFF mask on high byte) - Default digitalVolume to 1.0 instead of 0.5 (was halving signal) - Fix icon lookup: use wren.png instead of icon.png in build script
- Add Msi and Dmg target formats to native distributions - Add distro job to CI that builds on Linux, Windows, and macOS - Upload artifacts for all three platforms
…recation warning - checkout: v4 → v6 - setup-java: v4 → v5 - setup-gradle: v4 → v6 - upload-artifact: v4 → v6
Nxssie
force-pushed
the
feature/test-introduction
branch
from
21ed949 to
6409e0f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
setPixelFormatwas used for audio (it's a video option) — changed tosetOption("sample_fmt", "s16")icon.pngbut asset iswren.pngChanges
FFmpegPlayer.kt: audio format fix, digital volume gain with proper byte masking, removed MASTER_GAINbuild-appimage.sh: icon file name corrected