fix(discord): show 'Watching <title>' instead of 'Playing Nuvio' - #628
Open
maximedeprince wants to merge 1 commit into
Open
fix(discord): show 'Watching <title>' instead of 'Playing Nuvio'#628maximedeprince wants to merge 1 commit into
maximedeprince wants to merge 1 commit into
Conversation
The desktop Discord Rich Presence never set an activity type, so Discord fell back to type 0 (Playing) and displayed 'Playing Nuvio' with a game icon while watching a movie or show. - Set the Watching activity type (3) during playback. - Put the media title in the activity name (the line shown under the username) as well as in details, so Discord shows what is being watched. Recent clients render the title on the top line; older ones fall back to the app name and still show the title in details. - Add an end timestamp (start + duration) so Discord draws a progress bar with the time remaining. This required exposing the stream duration in the player presence snapshot. Fixes NuvioMedia#591
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the desktop Discord Rich Presence showing "Playing Nuvio" with a game icon while watching. It now shows the media title with the Watching activity type, plus a progress bar.
PR type
Why
The Discord presence never set an activity
type, so Discord fell back to type0(Playing) and displayed "Playing Nuvio" with a game icon during playback, instead of what the user is watching. Reported in #591.Desktop scope
Windows/macOS/Linux desktop. The change is in the desktop-only
discordrpccode; one shared field (durationMs) was added to the desktop player presence snapshot incommonMainto feed the progress bar, and is only consumed by the desktop Discord presence.Issue or approval
Fixes #591
UI / behavior impact
Policy check
CONTRIBUTING.md.Scope boundaries
Only the Discord Rich Presence payload is changed (activity
type,name,details/state, and anendtimestamp). No player, UI, or app behavior is touched beyond the presence shown to Discord. No new dependencies.Testing
Built the Windows desktop app from this branch and watched a show and a movie with Rich Presence enabled:
Note on client behavior: recent Discord clients render the custom
nameon the top line; older clients ignore it and fall back to the app name, in which case the title is still visible viadetails.Screenshots / Video
Not a UI change (the app UI is unchanged; only the external Discord presence card changes).
Breaking changes
None.
Linked issues
Fixes #591