Keyboard Arrow Navigation by aelrased · Pull Request #180 · NuvioMedia/NuvioDesktop

aelrased · 2026-06-29T05:48:12Z

Summary

PR type

Reproducible bug fix
UI glitch/bug fix
Behavior bug/regression fix
Small maintenance only, with no UI or behavior change
Docs accuracy fix
Translation/localization only
Approved larger or directional change

Why

Desktop scope

Issue or approval

UI / behavior impact

No UI change
No behavior change
UI changed only to fix a documented glitch/bug
Behavior changed only to fix a documented bug/regression
UI change has explicit maintainer approval
Behavior change has explicit maintainer approval

Policy check

I have read and understood CONTRIBUTING.md.
This PR is small, focused, and limited to one problem.
This PR is scoped to the desktop app, desktop packaging, desktop documentation, or shared code required for desktop behavior.
This PR is not cosmetic-only.
Any UI change fixes a linked glitch/bug and includes visual proof, or this PR has no UI change.
Any behavior change fixes a linked bug/regression or has explicit approval, or this PR has no behavior change.
This PR does not bundle unrelated refactors, cleanups, formatting, or drive-by changes.
This PR does not add dependencies, architecture changes, migrations, or product-direction changes without explicit approval.
I listed the testing performed below.

UI polish, cosmetic-only changes, minor behavior tweaks, and unapproved product changes will be closed without review.

Scope boundaries

Testing

Screenshots / Video

Breaking changes

Linked issues

aelrased · 2026-06-29T05:52:59Z

Summary — Keyboard Arrow Navigation

Problem

onPreviewKeyEvent does not work without a focused element in Compose Desktop
LazyRow/LazyColumn consume arrow key events before they reach the top level

Solution

Use AWT KeyEventDispatcher (same approach as installDesktopAppFullscreenShortcuts) to intercept arrow keys outside the Compose Focus system entirely.

New Files (5)

File	Description
`PlatformKeyboardNavigation.kt`	expect declaration
`PlatformKeyboardNavigation.desktop.kt`	AWT KeyEventDispatcher → focusManager.moveFocus() + fallback FocusDirection.Next
`PlatformKeyboardNavigation.android.kt`	no-op
`PlatformKeyboardNavigation.ios.kt`	no-op
`NuvioFocusable.kt`	Modifier.nuvioFocusBorder(shape) — draws a 3dp border using the theme's `focusRing` color around the element's actual shape

Modified Files (5)

File	Change
`App.kt`	Moved `PlatformKeyboardNavigation()` to `App()` root (works on all screens). Added `nuvioFocusBorder` to `TabletTopPillItem` and `DesktopSidebarItem`
`NavigationBar.kt`	Added `nuvioFocusBorder` to all 3 `NavItem` overloads
`ProfileSelectionScreen.kt`	Added `nuvioFocusBorder` to `ProfileAvatarCard` and `AddProfileCard`
`ShelfComponents.kt`	Added `nuvioFocusBorder` to `NuvioPosterCard`
`SettingsComponents.kt`	Added `nuvioFocusBorder` to `SettingsSidebarItem`, `SettingsNavigationRow`, `SettingsSwitchRow`

Focusable Elements

Bottom nav bar, desktop sidebar, tablet top pills, poster cards, profile avatar cards, add profile button, and settings items.

DustinBryant · 2026-07-10T23:15:17Z

    Column(
        modifier = Modifier
            .posterCardClickable(onClick = onClick, onLongClick = onLongClick)
+            .nuvioFocusBorder(cardShape)


This part isn't working for the poster cards for me because .posterCardClickable is swallowing the events it needs. If you put .nuvioFocusBorder first ahead of .posterCardClickable you get the desired functionality.

Thanks for catching that! Fixed in the latest push.

What changed:

Moved .nuvioFocusBorder() from the inner Box to the Column modifier on SeasonPosterButton, placed before .posterCardClickable so the focus ring receives keyboard events before the click handler swallows them.

The episode card already had the correct order (.nuvioFocusBorder before .posterCardClickable), so no change needed there.

All other components (StreamCard, StreamsScreen filter chips, DetailActionButtons, DetailCastSection avatars) were already correct.

aelrased · 2026-07-12T01:12:07Z

@DustinBryant Good catch! I've pushed a fix — moved .nuvioFocusBorder(cardShape) before .posterCardClickable(...) so the focus ring can receive keyboard events before the clickable modifier intercepts them. The change is on the keyboard-nav branch now.

- Merged upstream NuvioMedia/NuvioDesktop Dev (58+ commits) - Reverted custom player modifications, adopted upstream Linux player - Deleted obsolete files (LinuxDesktopIntegration, old player hosts, etc.) - Rewrote PR NuvioMedia#180 keyboard navigation for current codebase: - PlatformKeyboardNavigation: AWT KeyEventDispatcher for arrow keys - NuvioFocusable: Modifier.nuvioFocusBorder() for visual focus rings - Applied focus borders to NavigationBar, ShelfComponents, ProfileSelection, Settings - No-op implementations for Android/iOS

DustinBryant · 2026-09-01T04:59:03Z

@KhooLy can we get some eyes on this?

It would address:
#267
#33
#305

This change would bring in many more users with Home Theatre PCs (HTPC). Right now we're mostly stuck with Stremio but desperately want Nuvio.

KhooLy · 2026-09-05T13:29:58Z

Good direction, but the global KeyEventDispatcher currently consumes every arrow key press across the app, even when focus movement isn't handled. This can interfere with text fields, sliders, scrolling and other components that need their own arrow-key behavior. Please only consume the event when appropriate, and make the focus/navigation behavior desktop-only rather than changing shared mobile focus behavior. Also please rebase onto current Dev and update the PR description/testing, since this is a behavior/UI feature rather than maintenance.

Add keyboard arrow navigation support for desktop using AWT KeyEventDispatcher, with visual focus rings (border) on all focusable UI elements. New files: - PlatformKeyboardNavigation.kt (expect/actual) - PlatformKeyboardNavigation.desktop.kt (AWT KeyEventDispatcher) - PlatformKeyboardNavigation.android.kt / .ios.kt (no-op) - NuvioFocusable.kt (Modifier.nuvioFocusBorder) Modified files: - App.kt: Register PlatformKeyboardNavigation in AppEnvironment - NavigationBar.kt: Focus border on all NavItem variants - ShelfComponents.kt: Focus border on NuvioPosterCard - ProfileSelectionScreen.kt: Focus border on ProfileAvatarCard and AddProfileCard - SettingsComponents.kt: Focus border on SettingsSidebarItem, SettingsNavigationRow, SettingsSwitchRow

aelrased · 2026-09-07T03:45:25Z

Thanks for the review feedback - all three points have been addressed in the latest push:

Smart arrow key consumption - PlatformKeyboardNavigation.desktop.kt now inspects the focused AWT component before consuming arrow keys. It only consumes when the focus is on a Compose-managed focusable (not JTextField, JTextArea, JSpinner, JSlider, JScrollPane, or Scrollable), so text fields, sliders, scroll panes and other AWT components retain their native arrow-key behavior.
Desktop-only - .focusable() in NuvioFocusable.kt is now guarded with isDesktop, so mobile platforms are completely unaffected.
Rebased onto current Dev - Branch has been rebased onto upstream/Dev (21aabee).

Other changes in this push:

Fixed modifier ordering on SeasonPosterButton - .nuvioFocusBorder() moved before .posterCardClickable() per the inline review comment, so the focus ring receives keyboard events before the click handler can swallow them.
Added focus rings to StreamCard, StreamsScreen filter chips, DetailActionButtons (Play / More), DetailCastSection avatars, and all episode card variants.

Build verified successfully. Ready for another review.

…nents - PlatformKeyboardNavigation: skip consuming arrows when focused on JTextField, JTextArea, JSpinner, JSlider, JScrollPane, Scrollable - NuvioFocusable: guard .focusable() with isDesktop (desktop-only) - DetailActionButtons: nuvioFocusBorder on Play and More buttons - DetailSeriesContent: nuvioFocusBorder on season chips, season posters, episode horizontal cards, episode list cards - DetailCastSection: nuvioFocusBorder on cast avatar circles - StreamCard: nuvioFocusBorder on stream link cards - StreamsScreen: nuvioFocusBorder on provider filter chips

…Button The focus ring was on the inner Box but posterCardClickable on the Column was swallowing keyboard events. Move nuvioFocusBorder to the Column modifier chain ahead of posterCardClickable so focus works correctly.

aelrased force-pushed the keyboard-nav branch from c7fdc6a to 2e7dd39 Compare June 29, 2026 05:54

aelrased changed the title ~~Keyboard nav~~ Keyboard Arrow Navigation Jun 29, 2026

DustinBryant reviewed Jul 10, 2026

View reviewed changes

DustinBryant mentioned this pull request Aug 29, 2026

[Feature]: TV First GUI Layout and Controls #305

Open

aelrased force-pushed the keyboard-nav branch from dcc75db to 5b30e83 Compare August 31, 2026 04:16

aelrased force-pushed the keyboard-nav branch from c4c49ed to d71703c Compare September 7, 2026 03:45

ahmed added 2 commits September 6, 2026 23:45

Navigation Menu

Uh oh!

Keyboard Arrow Navigation - #180

Keyboard Arrow Navigation#180
aelrased wants to merge 3 commits into
NuvioMedia:Devfrom
aelrased:keyboard-nav

aelrased commented Jun 29, 2026 •

edited

Loading

Uh oh!

aelrased commented Jun 29, 2026 •

edited

Loading

Uh oh!

DustinBryant Jul 10, 2026

Uh oh!

aelrased Sep 7, 2026

Uh oh!

aelrased commented Jul 12, 2026

Uh oh!

DustinBryant commented Sep 1, 2026

Uh oh!

KhooLy commented Sep 5, 2026

Uh oh!

aelrased commented Sep 7, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

aelrased commented Jun 29, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

PR type

Why

Desktop scope

Issue or approval

UI / behavior impact

Policy check

Scope boundaries

Testing

Screenshots / Video

Breaking changes

Linked issues

Uh oh!

aelrased commented Jun 29, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary — Keyboard Arrow Navigation

Problem

Solution

New Files (5)

Modified Files (5)

Focusable Elements

Uh oh!

DustinBryant Jul 10, 2026

Choose a reason for hiding this comment

Uh oh!

aelrased Sep 7, 2026

Choose a reason for hiding this comment

Uh oh!

aelrased commented Jul 12, 2026

Uh oh!

DustinBryant commented Sep 1, 2026

Uh oh!

KhooLy commented Sep 5, 2026

Uh oh!

aelrased commented Sep 7, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

aelrased commented Jun 29, 2026 •

edited

Loading

aelrased commented Jun 29, 2026 •

edited

Loading