Conversation
`freshwater_tracer_content = (; X = RiverConcentration(c))` makes tracer X enter the ocean only with land (river) runoff, at concentration c: its content flux is c * Jʳ, where Jʳ is the runoff volume flux (m/s, positive into the ocean). Rain, snow, evaporation, icebergs and sea ice carry none of the tracer but still dilute it. - `hydrostatic_ocean_simulation` allocates one shared `river_freshwater_volume_flux` Field only when some tracer uses `RiverConcentration`, and materializes each entry into an internal `RiverTracerContent`. - `net_fluxes(ocean)` exposes `river_freshwater_volume_flux` (the Field or `nothing`). - `_assemble_net_ocean_fluxes!` writes the land runoff `Jˡⁿ / ρᵒᶜ` into it (zero on inactive nodes; no-op when `nothing`). - Correct the `freshwater_tracer_content` docstring: it is a tracer flux Σᵢ cᵢ Jʷᵢ, not a concentration. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Checks that a `RiverConcentration(c)` tracer's content is c times the shared runoff volume flux field (other tracers untouched), that with a prescribed land the coupled model fills `river_freshwater_volume_flux` with the land runoff divided by the ocean reference density (>= 0, nonzero, zero on land), and that the field is `nothing` when no tracer uses `RiverConcentration`. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
jagoosw
marked this pull request as ready for review
October 1, 2026 13:37
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds
RiverConcentrationwhich can be passed tofreshwater_tracer_contentand it fills the freshwater flux into the tracer with concentration x volume flux.