Align bench delta formatting with ember-eslint-parser - #71
Merged
NullVoxPopuli merged 1 commit intoJul 3, 2026
Merged
Conversation
Ports ember-eslint-parser's delta classification: a 2% noise floor, green for any improvement beyond noise, a distinct "slightly slower" band at 2-5%, and red at 5%+. The old symmetric "within 5%" yellow hid real 2-5% wins and regressions behind the same neutral marker. Also extracts the shared helpers (formatTime, deltaEmoji, parsePairs, readBenchJSON) into scripts/bench-utils.mjs, mirroring ember-eslint- parser's layout, so the CLI and PR-comment formatters can't drift apart. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ports ember-eslint-parser's benchmark delta calculation/formatting, so both repos' bench tooling reads the same way.
What changed
scripts/bench-utils.mjs:formatTime,deltaEmoji,parsePairs,readBenchJSON, and the legend now live in one module used by bothformat-bench-cli.mjsandformat-bench-comment.mjs(previously duplicated, and their thresholds had already drifted: the CLI/comment used a 1% white band while ember-eslint-parser uses 2%).Example output
Verified with a synthetic results file covering all four bands (CLI table + PR comment markdown);
pnpm lintclean.🤖 Generated with Claude Code