Add print support for TSParenthesizedType - #63
Merged
Conversation
`print` threw `unsupported node type 'TSParenthesizedType'` on a
parenthesized type like `type X = (A | B)[];` — oxc-parser preserves the
parens as a TSParenthesizedType (single `typeAnnotation` child), the
type-level analog of ParenthesizedExpression, but the printer had no case.
Print it as `(${typeAnnotation})`. Covered by a unit test and a
parse+print round-trip.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Contributor
🏎️ Benchmark Comparison
Full mitata output |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
printthrewunsupported node type 'TSParenthesizedType'on a parenthesized type such astype X = (A | B)[];. oxc-parser preserves the parens as aTSParenthesizedTypenode (singletypeAnnotationchild) — the type-level analog ofParenthesizedExpression— but the printer had no case, so it hit theunsupported node typethrow.Change
Add the case:
(${print(node.typeAnnotation)}).Tests
print.test.js:TSParenthesizedTypewrapping a union.parse-print-gts.test.js: round-trip oftype X = (A | B)[];.oxlint+oxfmt --check+publintclean.🤖 Generated with Claude Code