Skip NU1703 for empty MonoAndroid assets#7511
Open
sbomer wants to merge 2 commits into
Open
Conversation
Avoid emitting the MonoAndroid deprecation warning when restore selects only _._ placeholder assets from a package. Keep warning behavior for packages that contribute real MonoAndroid compile or runtime assets. Assisted-by: GitHub Copilot CLI:gpt-5.5 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
dotnet-policy-service
Bot
added
the
Community
nkolev92
reviewed
Jun 25, 2026
nkolev92
left a comment
nkolev92
left a comment
Member
There was a problem hiding this comment.
small suggestion. LGTM
Please keep the PR template for PRs.
Remove the unnecessary null-conditional when checking selected MonoAndroid assets; restore passes non-null asset collections. Assisted-by: GitHub Copilot CLI:gpt-5.5 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
nkolev92
approved these changes
Jun 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Avoid emitting the MonoAndroid deprecation warning (introduced in #7229) when restore selects only . placeholder assets from a package. Keep warning behavior for packages that contribute real MonoAndroid compile or runtime assets.
The warning was showing up on a transitive reference to System.Security.Cryptography.ProtectedData 4.5.0 in dotnet/runtime#129836, but we don't want it to warn when no assets are used from the MonoAndroid TFM.
Assisted-by: GitHub Copilot CLI:gpt-5.5
@nkolev92 PTAL
Bug
Fixes:
NU1903 showing up on reference to old package with MonoAndroid TFM but no MonoAndroid assets, in dotnet/runtime#129836.
Description
The warning added in #7229 fires for packages that declare a MonoAndroid TFM but only ship an empty
_._placeholder for TFM compatibility. We shouldn't emit the warning if no MonoAndroid assets are consumed.PR Checklist