Update packages #6358
Open
Update packages #6358
+28
−39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zivkan
requested changes
Mar 28, 2025
jeffkl
force-pushed
the
dev-jeffkl-update-packages
branch
from
c9a4074 to
d760ec2
Compare
nkolev92
reviewed
Mar 31, 2025
| <PackageReference Include="Microsoft.Build" IncludeAssets="None" PrivateAssets="all"/> | ||
| <PackageReference Include="Microsoft.Build.Framework" IncludeAssets="None" PrivateAssets="all"/> | ||
| <PackageReference Include="Microsoft.Build" IncludeAssets="None" PrivateAssets="all" /> | ||
| <PackageReference Include="Microsoft.Build.Framework" IncludeAssets="None" PrivateAssets="all" NoWarn="NU1605" /> |
There was a problem hiding this comment.
What's the downgrade we're suppressing here?
This is not your change, but do you know why we have an IncludeAssets="None", PrivateAssets="all" package? Is it forcing some specific resolution?
zivkan
approved these changes
Mar 31, 2025
martinrrm
approved these changes
Apr 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug
Fixes: https://github.com/NuGet/Client.Engineering/issues/3211
Description
This updates packages to ensure that we're not using a version of MessagePack with known vulnerabilities. This gets us onto versoin 2.5.295 which is what Visual Studio currently has an assembly binding redirect to:
PR Checklist