fix: implement session token rotation on authentication (#366)#373
Open
anshul23102 wants to merge 1 commit into
Open
fix: implement session token rotation on authentication (#366)#373anshul23102 wants to merge 1 commit into
anshul23102 wants to merge 1 commit into
Conversation
Contributor
Author
|
✅ GSSoC 2026 Contribution @Nsanjayboruds Could you please add the |
Contributor
Author
|
Bump for review: PR ready for merge. GSSoC 2026 tracked. Summary: Implements session token rotation after privilege change (login/role update). Includes:
Testing: ✅ Privilege change handling | ✅ Token rotation | ✅ Session invalidation Please review and merge. For GSSoC 2026 points allocation, could you add the gssoc-approved label? /review |
Contributor
Author
|
Bump for review: PR ready for merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Implements session token rotation on successful authentication to prevent session fixation attacks where attackers pre-plant known session tokens.
Why is it needed?
Session fixation is a critical security vulnerability (OWASP A07:2021). When users login or their privileges change, the session token must be rotated to invalidate any pre-planted tokens an attacker may control.
Implementation details
req.session.regenerate()on successful loginjticlaimFiles modified
Testing
Fixes #366