Conversation
- Completely redesigned config.yml with modular template system - Implemented group-based formatting with LuckPerms integration - Separated templates for hovers, prefixes, and name styles - Added channel persistence to remember player's last active channel - Created clear separation between channel prefixes and group prefixes - Improved message visibility isolation between channels - Added customizable chat format with flexible placeholders - Enhanced username styling with gradients, colors, and effects Closes #3
There was a problem hiding this comment.
Pull Request Overview
This PR implements a complete revamp of the plugin configuration using a modular template system and introduces group-based formatting with LuckPerms integration for enhanced chat customization and channel persistence. Key changes include redesigned configuration files with separated templates for hovers, prefixes, and name styles, the addition of group-based formatting logic integrated with LuckPerms, and improvements to channel persistence and message formatting.
Reviewed Changes
Copilot reviewed 12 out of 12 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/main/resources/plugin.yml | Updated softdepend to include LuckPerms. |
| src/main/resources/config.yml | Redesigned config with new options for group formatting, templates, and chat format. |
| src/main/java/com/noximity/remmyChat/services/PermissionService.java | Added LuckPerms integration via reflection for group-based formatting. |
| src/main/java/com/noximity/remmyChat/services/FormatService.java | Refactored message formatting to support group and channel prefixes and hovers. |
| src/main/java/com/noximity/remmyChat/models/** | Updated models (Channel and GroupFormat) to support new configuration structure. |
| src/main/java/com/noximity/remmyChat/listeners/ChatListener.java | Updated permission checks and channel management logic for improved functionality. |
| src/main/java/com/noximity/remmyChat/database/DatabaseManager.java | Enhanced database management with reconnection handling and channel persistence. |
| src/main/java/com/noximity/remmyChat/config/ConfigManager.java | Added template loading for hovers, prefixes, and name styles; loaded group formats. |
| src/main/java/com/noximity/remmyChat/RemmyChatPlaceholders.java | Updated placeholder logic for channel and group integration. |
| src/main/java/com/noximity/remmyChat/RemmyChat.java | Integrated the new PermissionService and updated plugin initialization. |
| pom.xml | Increased version and added LuckPerms dependency and repository. |
| chat-cooldown: 3 | ||
|
|
||
| # URL formatting options | ||
| # URL formatting optionsxw |
There was a problem hiding this comment.
The comment contains a typo ('optionsxw'). It should be corrected to 'URL formatting options'.
Suggested change
| # URL formatting optionsxw | |
| # URL formatting options |
| default: "<#4A90E2>%player_name%" | ||
| owner: "<bold><gradient:#FF0000:#FFAA00>%player_name%</gradient></bold>" | ||
| admin: "<italic><color:#CC44FF>%player_name%</color></italic>" | ||
| mod: "<underlined><color:#33CCFF>%player_name%</underlined>" |
There was a problem hiding this comment.
The 'mod' name style appears to have unbalanced formatting tags. Consider updating it to include a closing tag, e.g. "color:#33CCFF%player_name%", to ensure proper formatting.
Suggested change
| mod: "<underlined><color:#33CCFF>%player_name%</underlined>" | |
| mod: "<underlined><color:#33CCFF>%player_name%</color></underlined>" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #3