Skip to content

[bug][examples] Fix lcb dataset issue in examples dir #1349

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
s-chundi wants to merge 1 commit into
base: main
Choose a base branch
from
+9 −16
Open

[bug][examples] Fix lcb dataset issue in examples dir #1349

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 7 additions & 14 deletions examples/train/livecodebench/lcb_dataset.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
import os
from typing import Any, Dict, List, Optional

import pandas as pd
import datasets as hf_datasets

"""Utility functions for loading and processing datasets."""

Expand Down Expand Up @@ -145,17 +145,11 @@ def process_dataset(dataset_name: str, split: str, dataset_dir: str, local_dir:
if max_rows:
processed_data = processed_data[:max_rows]

# Save individual dataset files
df = pd.DataFrame(processed_data)
ds = hf_datasets.Dataset.from_list(processed_data)
parquet_path = os.path.join(local_dir, f"{split}_{dataset_name}.parquet")
json_path = os.path.join(local_dir, f"{split}_{dataset_name}.json")

print(f"Writing {len(df)} rows to {split}_{dataset_name}.parquet")
df.to_parquet(parquet_path)

if split == "test":
print(f"Writing {len(df)} rows to {split}_{dataset_name}.json")
df.to_json(json_path, orient="records")
print(f"Writing {len(ds)} rows to {split}_{dataset_name}.parquet")
ds.to_parquet(parquet_path)

return processed_data

Expand Down Expand Up @@ -194,7 +188,6 @@ def process_dataset(dataset_name: str, split: str, dataset_dir: str, local_dir:
val_data = process_dataset(LIVECODEBENCH, "test", args.dataset_dir, local_dir, args.max_rows)

# Save combined train dataset
all_train_df = pd.DataFrame(train_data)
all_train_df.to_parquet(os.path.join(local_dir, "deepcoder_train.parquet"))
all_train_df.to_json(os.path.join(local_dir, "deepcoder_train.json"), orient="records")
print(f"Writing {len(all_train_df)} rows to deepcoder_train.parquet and deepcoder_train.json")
all_train_ds = hf_datasets.Dataset.from_list(train_data)
all_train_ds.to_parquet(os.path.join(local_dir, "deepcoder_train.parquet"))
print(f"Writing {len(all_train_ds)} rows to deepcoder_train.parquet")
4 changes: 2 additions & 2 deletions examples/train/livecodebench/run_lcb.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,8 @@ set -x
# bash examples/livecodebench/run_lcb.sh

DATA_DIR="$HOME/data/lcb"
train_data="['${DATA_DIR}/deepcoder_train.json']"
val_data="['${DATA_DIR}/test_livecodebench.json']"
train_data="['${DATA_DIR}/deepcoder_train.parquet']"
val_data="['${DATA_DIR}/test_livecodebench.parquet']"

# NOTE (sumanthrh): micro_train_batch_size and micro_forward_batch_size can be tuned
uv run --isolated --frozen --extra fsdp -m skyrl.train.entrypoints.main_base \
Expand Down