fix: forward base_url and api_key from fallback config to resolve_provider_client#4784
Open
tomwhipple wants to merge 1 commit intoNousResearch:mainfrom
Open
Conversation
…vider_client When a custom fallback model is configured with an explicit base_url (e.g. a local Ollama endpoint), _try_activate_fallback was not passing it as explicit_base_url to resolve_provider_client. The custom provider then fell through to the primary provider's credentials, routing the fallback model slug to the wrong API endpoint and returning a 404. Adds explicit_base_url and explicit_api_key forwarding, and strengthens the existing test plus adds a regression test that asserts the kwargs are passed. Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
_try_activate_fallbackwas callingresolve_provider_clientwithout forwardingbase_urlorapi_keyfrom the fallback configprovider: customwith an explicitbase_url, this caused the router to fall through to the primary provider's credentials — routing the fallback model slug to the wrong endpoint and returning a 404explicit_base_url=fb.get("base_url")andexplicit_api_key=fb.get("api_key")in the call🤖 Generated with Claude Code