fix: add memory provider dispatch to sequential tool execution path#4780
Closed
ukint-vs wants to merge 1 commit intoNousResearch:mainfrom
Closed
fix: add memory provider dispatch to sequential tool execution path#4780ukint-vs wants to merge 1 commit intoNousResearch:mainfrom
ukint-vs wants to merge 1 commit intoNousResearch:mainfrom
Conversation
The sequential tool dispatch in `_execute_tool_calls_sequential()` was missing the memory manager check that exists in the concurrent path (`_invoke_tool()`). This caused external memory provider tools (e.g. mem0_profile, mem0_search, mem0_conclude) to fall through to the registry, which returned "Unknown tool" errors. Single tool calls in quiet_mode (used by the gateway for Telegram/Discord) always take the sequential path, so memory provider tools were completely broken on all gateway platforms. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Contributor
|
Already fixed on main via PR #4803 (merged). The memory provider dispatch block in _execute_tool_calls_sequential is identical to this fix. Thanks for catching the same issue! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
_execute_tool_calls_sequential()was missing the_memory_manager.has_tool()check that exists in the concurrent path (_invoke_tool())quiet_mode(always used by the gateway) take the sequential path, so memory provider tools were completely broken on all gateway platformsFix
Added the memory manager dispatch (5 lines) to the sequential tool execution path, matching what already exists in
_invoke_tool()at line ~5620.Test plan
🤖 Generated with Claude Code