-
Notifications
You must be signed in to change notification settings - Fork 68
Summaries 0.22.1 #567
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Summaries 0.22.1 #567
Conversation
If lines start to wrap the formating breaks.
Typos Resize images
I'm happy with the tidy up and documentation changes. (Longer term I want to be able to generate and insert proper graphical sparkline graphs here instead of the 'ASCII Art', but the necessary support isn't really available in NP yet.) |
Your right truncating will look better. Ill make a new ps. |
Thanks for checking with me on this. |
Ah yes, nice catch. we have seen this issue in the main app also. I would suggest filtering out links and replacing with the text in the brackets before truncating. @jgclark do we have a helper for this? We certainly have code which could be helpful when we convert markdown links to HTML links. |
Signed-off-by: Aaron Gascoigne <[email protected]>
Done, while I was there added template render shoutout @mikeerickson for good code. Code looks right however I am running into a bug I have seen before were "await" is not honored and code execution continues before the promise is completed. I thought it was related to date returned by Np but it seems its on the
|
|
||
await occObjs.forEach(async (m) => { | ||
if (m.term.includes('<%') && m.term.includes('%>')) { | ||
m.term = await NPTemplating.render(m.term) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is returning late
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure what you're trying to achieve here when you say simply "render templates".
Nor do I know the Templating code, and as it's not well documented, it would take me a very long time to figure out. So I can't help. Do you want to back out this part of the PR for now?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks pretty cool to me. You could include template code in the title. Sounds like it could be useful. @aaronpoweruser What's your use case? And you tested it I assume.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@aaronpoweruser Can you pls provide some test examples that show how your new code is used, especially the new template parts? I don't see any mention of the template strings in the README. I may have missed it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, I can update the documentation, this was a for me feature. As I dynamically generate a link to my weekly note.
@dwertheimer I wonder if this is related to the issue I'm seeing where commands in templates are returning |
No description provided.