Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

flake: update npins pins for themes #627

Merged
merged 3 commits into from
Feb 11, 2025
Merged

Conversation

Just-Helpful
Copy link
Contributor

@Just-Helpful Just-Helpful commented Feb 11, 2025

Reverts the attribute names for theme plugins provided in npins/sources.json.
These were causing the neovim flakes with the following themes to fail to build:

  • "base16"
  • "dracula"
  • "gruvbox"
  • "nord"
  • "onedark"
  • "oxocarbon"
  • "tokyonight"

See:

Sanity Checking

  • I have updated the changelog as per my changes
  • I have tested, and self-reviewed my code
  • My changes fit guidelines found in hacking nvf
  • Style and consistency
    • I ran Alejandra to format my code (nix fmt)
    • My code conforms to the editorconfig configuration of the project
    • My changes are consistent with the rest of the codebase
  • If new changes are particularly complex:
    • My code includes comments in particularly complex areas
    • I have added a section in the manual
    • (For breaking changes) I have included a migration guide
  • Package(s) built:
    • .#nix (default package)
    • .#maximal
    • .#docs-html (manual, must build)
    • .#docs-linkcheck (optional, please build if adding links)
  • Tested on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin

Add a 👍 reaction to pull requests you find important.

@Just-Helpful Just-Helpful marked this pull request as ready for review February 11, 2025 18:17
github-actions bot pushed a commit that referenced this pull request Feb 11, 2025
Copy link

github-actions bot commented Feb 11, 2025

🚀 Live preview deployed from 0c63083

View it here:

Debug Information

Triggered by: NotAShelf

HEAD at: main

Reruns: 221

@Just-Helpful
Copy link
Contributor Author

Note: I haven't been able to build the documentation.
It looks like the documentation expects a ...-nvf-manual/bin/nvf-manual which isn't generated by the build.

Instead the build gives a documentation structure similar to:

/nix/store/8xrlmyrsxi46zajd7hlkvjhk9i1472iz-nvf-manual/:
nix-support  share

/nix/store/8xrlmyrsxi46zajd7hlkvjhk9i1472iz-nvf-manual/nix-support:
hydra-build-products

/nix/store/8xrlmyrsxi46zajd7hlkvjhk9i1472iz-nvf-manual/share:
doc

/nix/store/8xrlmyrsxi46zajd7hlkvjhk9i1472iz-nvf-manual/share/doc:
nvf

/nix/store/8xrlmyrsxi46zajd7hlkvjhk9i1472iz-nvf-manual/share/doc/nvf:
highlightjs  index.xhtml  options.html  quirks.html  release-notes.html  script  style.css

/nix/store/8xrlmyrsxi46zajd7hlkvjhk9i1472iz-nvf-manual/share/doc/nvf/highlightjs:
highlight.pack.js  LICENSE  loader.js  mono-blue.css

/nix/store/8xrlmyrsxi46zajd7hlkvjhk9i1472iz-nvf-manual/share/doc/nvf/script:
anchor-min.js  anchor-use.js  search.js

@NotAShelf
Copy link
Owner

It looks like the documentation expects a ...-nvf-manual/bin/nvf-manual which isn't generated by the build.

This should be exclusive to nix run, not build. Does nix build .#docs-html build?

@Just-Helpful
Copy link
Contributor Author

Just-Helpful commented Feb 11, 2025

Yep, it builds with nix build, I'll also try the .#docs-linkcheck and add it if it passes. Thanks!

@NotAShelf
Copy link
Owner

Seeing CI also passes, I'm merging this. Hoping that this is the last of the npins breakages.

@NotAShelf NotAShelf changed the title Corrects npin names for themes flake: update npins pins for themes Feb 11, 2025
@NotAShelf NotAShelf merged commit 0c63083 into NotAShelf:main Feb 11, 2025
13 checks passed
@NotAShelf
Copy link
Owner

Thank you!

Copy link

✅ Preview has been deleted successfully!

github-actions bot pushed a commit that referenced this pull request Feb 11, 2025
isaacST08 pushed a commit to isaacST08/nvf that referenced this pull request Feb 12, 2025
* fix: corrects theme names in `npins/sources.json`

See:
- [themes broken](NotAShelf#619)
- [lspkind broken](NotAShelf#624)

* release-notes: adds fix to plugin theme names
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants