Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lsp/lspkind: fix plugin name #626

Merged
merged 3 commits into from
Feb 11, 2025
Merged

lsp/lspkind: fix plugin name #626

merged 3 commits into from
Feb 11, 2025

Conversation

folospior
Copy link
Contributor

Fixes the lspkind plugin name after the change to npins.

Sanity Checking

  • I have updated the changelog as per my changes
  • I have tested, and self-reviewed my code
  • My changes fit guidelines found in hacking nvf
  • Style and consistency
    • I ran Alejandra to format my code (nix fmt)
    • My code conforms to the editorconfig configuration of the project
    • My changes are consistent with the rest of the codebase
  • If new changes are particularly complex:
    • My code includes comments in particularly complex areas
    • I have added a section in the manual
    • (For breaking changes) I have included a migration guide
  • Package(s) built:
    • .#nix (default package)
    • .#maximal
    • .#docs-html (manual, must build)
    • .#docs-linkcheck (optional, please build if adding links)
  • Tested on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin

Add a 👍 reaction to pull requests you find important.

@folospior folospior requested a review from NotAShelf as a code owner February 11, 2025 17:39
github-actions bot pushed a commit that referenced this pull request Feb 11, 2025
Copy link

github-actions bot commented Feb 11, 2025

🚀 Live preview deployed from 7eb1780

View it here:

Debug Information

Triggered by: NotAShelf

HEAD at: main

Reruns: 219

@folospior
Copy link
Contributor Author

Sorry about the double PR, I was 80% sure I broke it (now I'm 40% 😭 )

NotAShelf
NotAShelf previously approved these changes Feb 11, 2025
Copy link
Owner

@NotAShelf NotAShelf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you

github-actions bot pushed a commit that referenced this pull request Feb 11, 2025
@NotAShelf NotAShelf merged commit 7eb1780 into NotAShelf:main Feb 11, 2025
13 checks passed
Copy link

✅ Preview has been deleted successfully!

isaacST08 pushed a commit to isaacST08/nvf that referenced this pull request Feb 12, 2025
* lsp/lspkind: fix plugin name

* docs: update changelog

---------

Co-authored-by: raf <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants