Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: missing npins subcommands #623

Merged
merged 1 commit into from
Feb 11, 2025
Merged

docs: missing npins subcommands #623

merged 1 commit into from
Feb 11, 2025

Conversation

alfarelcynthesis
Copy link
Contributor

@alfarelcynthesis alfarelcynthesis commented Feb 11, 2025 •
edited
Loading

Adds missing add in the two npins commands, and fix a typo.

Sanity Checking

  • I have updated the changelog as per my changes
  • I have tested, and self-reviewed my code
  • My changes fit guidelines found in hacking nvf
  • Style and consistency
    • I ran Alejandra to format my code (nix fmt)
    • My code conforms to the editorconfig configuration of the project
    • My changes are consistent with the rest of the codebase
  • If new changes are particularly complex:
    • My code includes comments in particularly complex areas
    • I have added a section in the manual
    • (For breaking changes) I have included a migration guide
  • Package(s) built:
    • .#nix (default package)
    • .#maximal
    • .#docs-html (manual, must build)
    • .#docs-linkcheck (optional, please build if adding links)
  • Tested on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin

Add a 👍 reaction to pull requests you find important.

@alfarelcynthesis alfarelcynthesis marked this pull request as draft February 11, 2025 17:13
github-actions bot pushed a commit that referenced this pull request Feb 11, 2025
@actions-user
Deploy PR #623 preview
fc29845
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 11, 2025 •
edited
Loading

🚀 Live preview deployed from c4cb29b

View it here:

Debug Information

Triggered by: NotAShelf

HEAD at: missing-subcommand

Reruns: 212

@alfarelcynthesis alfarelcynthesis marked this pull request as ready for review February 11, 2025 17:16
@NotAShelf
Copy link
Owner

@Gerg-L naughty naughty

@NotAShelf NotAShelf changed the title Add missing npins subcommand to docs docs: missing npins subcommands Feb 11, 2025
@Gerg-L
Copy link
Contributor

Gerg-L commented Feb 11, 2025

(╯°□°）╯︵┻━┻

@NotAShelf NotAShelf merged commit c4cb29b into NotAShelf:main Feb 11, 2025
13 checks passed
@github-actions GitHub Actions
Copy link

✅ Preview has been deleted successfully!

github-actions bot pushed a commit that referenced this pull request Feb 11, 2025
@actions-user
Deploy PR #623 preview
6a152b6
isaacST08 pushed a commit to isaacST08/nvf that referenced this pull request Feb 12, 2025
@alfarelcynthesis @isaacST08
docs: add missing npins subcommand (NotAShelf#623)
2381358
@alfarelcynthesis alfarelcynthesis deleted the missing-subcommand branch February 13, 2025 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NotAShelf NotAShelf NotAShelf approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alfarelcynthesis @NotAShelf @Gerg-L