Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

languages/nix: add lsp options support for nixd #606

Merged
merged 2 commits into from
Feb 11, 2025

Conversation

iynaix
Copy link
Contributor

@iynaix iynaix commented Feb 7, 2025

Sanity Checking

  • I have updated the changelog as per my changes
  • I have tested, and self-reviewed my code
  • My changes fit guidelines found in hacking nvf
  • Style and consistency
    • I ran Alejandra to format my code (nix fmt)
    • My code conforms to the editorconfig configuration of the project
    • My changes are consistent with the rest of the codebase
  • If new changes are particularly complex:
    • My code includes comments in particularly complex areas
    • I have added a section in the manual
    • (For breaking changes) I have included a migration guide
  • Package(s) built:
    • .#nix (default package)
    • .#maximal
    • .#docs-html (manual, must build)
    • .#docs-linkcheck (optional, please build if adding links)
  • Tested on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin

Add a 👍 reaction to pull requests you find important.

@iynaix iynaix requested a review from NotAShelf as a code owner February 7, 2025 03:08
github-actions bot pushed a commit that referenced this pull request Feb 7, 2025
Copy link

github-actions bot commented Feb 7, 2025

🚀 Live preview deployed from c4cb29b

View it here:

Debug Information

Triggered by: NotAShelf

HEAD at: add-nixd-opts

Reruns: 213

modules/plugins/languages/nix.nix Outdated Show resolved Hide resolved
modules/plugins/languages/nix.nix Outdated Show resolved Hide resolved
modules/plugins/languages/nix.nix Outdated Show resolved Hide resolved
github-actions bot pushed a commit that referenced this pull request Feb 11, 2025
@NotAShelf
Copy link
Owner

@cronyakatsuki could you test this PR? If it works as intended, I'll merge it. Meanwhile, @iynaix if you could add an entry to the changelog that would be great. This is a noteworthy addition.

@cronyakatsuki
Copy link

@cronyakatsuki could you test this PR? If it works as intended, I'll merge it. Meanwhile, @iynaix if you could add an entry to the changelog that would be great. This is a noteworthy addition.

Can confirm it work's flawlessly when it comes to loading the nixos and home manager options.

github-actions bot pushed a commit that referenced this pull request Feb 11, 2025
@iynaix
Copy link
Contributor Author

iynaix commented Feb 11, 2025

Ok, I've added an entry to the changelog 😄

github-actions bot pushed a commit that referenced this pull request Feb 11, 2025
@NotAShelf NotAShelf merged commit ae677ce into NotAShelf:main Feb 11, 2025
13 checks passed
Copy link

✅ Preview has been deleted successfully!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants