Skip to content

Add tweak for the old creative menu#94

Open
Xenthio wants to merge 9 commits intoNostalgica-Reverie:1.21from
Xenthio:1.21-OldCreativeMenu
Open

Add tweak for the old creative menu#94
Xenthio wants to merge 9 commits intoNostalgica-Reverie:1.21from
Xenthio:1.21-OldCreativeMenu

Conversation

@Xenthio
Copy link
Collaborator

@Xenthio Xenthio commented Sep 25, 2024

This PR is a doozy and contains some less than satisfactory code for the sake of customisation.

@forkiesassds
Copy link
Member

I appreciate the effort, however I have a few problems with this pull request. First of all the code largely looks like it’s copied from an old version of Minecraft. Furthermore the blocks list is hardcoded with an unnecessary and very verbose option, it should be up to data packs to control the order and blocks listed. Additionally the 0.30 creative menu is very limited and not at all suitable for use apart from some niche cases.

@Xenthio
Copy link
Collaborator Author

Xenthio commented Sep 26, 2024

Not copied but a couple numbers were certainly referenced. The verboseness of the option is yeah dumb, but the creative menu without the old item layout would just look silly really.

@forkiesassds
Copy link
Member

Not copied but a couple numbers were certainly referenced. The verboseness of the option is yeah dumb, but the creative menu without the old item layout would just look silly really.

Variable names within the code suggest otherwise. Besides it should not be up to the mod itself to determine the item layout within the inventory

@Xenthio
Copy link
Collaborator Author

Xenthio commented Sep 26, 2024

Not copied but a couple numbers were certainly referenced. The verboseness of the option is yeah dumb, but the creative menu without the old item layout would just look silly really.

Variable names within the code suggest otherwise. Besides it should not be up to the mod itself to determine the item layout within the inventory

Ahh yeah okay i see them, I guess I forgot about those haha, those are mostly so creative inventory behaviours match with modern minecraft.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants