DP-5317 - Create hyperlinks in Excel#230
Merged
DeleTaylor merged 2 commits intomasterfrom Nov 24, 2025
Merged
Conversation
gvjoshi25
requested review from
Bryan-Noel,
DeleTaylor,
chlocarlos and
yaphet17
DeleTaylor
requested changes
Nov 24, 2025
| DataReader reader; | ||
| DataWriter writer; | ||
|
|
||
| reader = new MemoryReader(getOrderRecordList()); |
Contributor
There was a problem hiding this comment.
Can we add a comment on its own line saying: create "order_details" tab?
| writer = new ExcelHyperlinkProxyWriter(writer); | ||
| Job.run(reader, writer); | ||
|
|
||
| reader = new MemoryReader(getProductRecordList()); |
Contributor
There was a problem hiding this comment.
Can we add a comment on its own line saying: create "product_details" tab?
DeleTaylor
requested changes
Nov 24, 2025
|
|
||
| @Override | ||
| protected Record interceptRecord(Record record) throws Throwable { | ||
| for (int i = 0; i < record.getFields().size(); i++) { |
Contributor
There was a problem hiding this comment.
Let's use the enhanced "for" directly on the record.
DeleTaylor
approved these changes
Nov 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.