Conversation
chlocarlos
requested review from
Bryan-Noel,
DeleTaylor,
gvjoshi25 and
yaphet17
DeleTaylor
requested changes
Nov 20, 2025
| import com.northconcepts.datapipeline.job.Job; | ||
| import com.northconcepts.datapipeline.memory.MemoryReader; | ||
|
|
||
| public class GroupByAndCollectValues { |
Contributor
There was a problem hiding this comment.
- Can we rename this to
AddValuesToAnArrayUsingGroupByReader? - Any chance we can make this simpler? Maybe use just one
GroupByReaderand oneJob.run? It's hard to see the example as-is.
Renamed GroupByAndCollectValues.java to AddValuesToAnArrayUsingGroupByReader.java and simplified the example to focus on grouping by category, summing prices, and collecting products into an array. Removed duplicate and distinct product collection logic for clarity.
DeleTaylor
approved these changes
Nov 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.