Skip to content

DP-3332 - Parse Invalid Expressions #171

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
gvjoshi25 wants to merge 2 commits into
base: master
Choose a base branch
from
Open

DP-3332 - Parse Invalid Expressions #171

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6277870
DP-3332 - Parse Invalid Expressions
gvjoshi25 Jul 4, 2023
d63f999
changes as per review comments
gvjoshi25 Jul 9, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
47 changes: 47 additions & 0 deletions src/main/java/com/northconcepts/datapipeline/examples/cookbook/ParseInvalidExpressions.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,47 @@
package com.northconcepts.datapipeline.examples.cookbook;

import com.northconcepts.datapipeline.internal.expression.Expression;
import com.northconcepts.datapipeline.internal.expression.InvalidSyntax;
import com.northconcepts.datapipeline.internal.parser.Parser;

public class ParseInvalidExpressions {

public static void main(String[] args) {
parseAnInvalidExpression();
parseInvalidExpressions();
}

private static void parseAnInvalidExpression() {
System.out.println("=========================== Parse An Invalid Expression =======================================");
// Parse an invalid expression which is missing closing parenthesis

Expression expression = Parser.parseExpression("toInt('123'", true);
executeExpression(expression);
}

private static void executeExpression(Expression expression) {
InvalidSyntax invalidSyntax = (InvalidSyntax) expression;
Copy link
Contributor

@DeleTaylor DeleTaylor Jul 9, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's extract this code as a separate method (executeExpression(Expression expression)) for use here and with the 2 expressions below.

Copy link
Contributor Author

@gvjoshi25 gvjoshi25 Jul 9, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Created this common method.

System.out.println("Source Expression: " + invalidSyntax.getSourceString());
System.out.println("Expression Parse Exception: " + invalidSyntax.getParseException().getMessage());

try {
System.out.println(expression.evaluate(null));
} catch (Throwable e) {
System.err.println("Exception while evaluating invalid expression: " + e.getMessage());
}
}

private static void parseInvalidExpressions() {
System.out.println("=========================== Parse Multiple Invalid Expression =================================");

Parser.doWithoutParseException(() -> {
Expression expression1 = Parser.parseExpression("toInt('123'");
executeExpression(expression1);

System.out.println("=============================================================================");

Expression expression2 = Parser.parseExpression("toInt('345'");
executeExpression(expression2);
});
}
}