-
-
Notifications
You must be signed in to change notification settings - Fork 555
chore: remove antigravity-claude-opus-4-5-thinking #437
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Fixes: NoeFabris#424 - Removed `antigravity-claude-opus-thinking-4-5` from `README.md` - modified `antigravity-claude-opus-thinking-4-5` on `bug_report.yml`
Signed-off-by: Tito <github@mynameistito.com>
- Remove antigravity-claude-opus-4-5-thinking from model definitions - Remove Opus 4.5 MODEL_ALIASES entries - Update all tests to use Opus 4.6 instead of 4.5 - Update scripts (test-regression, test-models, test-cross-model, test-cross-model-e2e.sh) - Update documentation (README, AGENTS.md, API spec, bug report template) - Update comment in request.ts All 833 tests pass, typecheck and build succeed. Fixes NoeFabris#424
WalkthroughThis pull request removes references to Claude Opus 4-5 and replaces them with Claude Opus 4-6 across the repository. Changes include deleting the Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. No actionable comments were generated in the recent review. 🎉 🧹 Recent nitpick comments
📜 Recent review detailsConfiguration used: Repository UI Review profile: CHILL Plan: Pro Cache: Disabled due to data retention organization setting Knowledge base: Disabled due to data retention organization setting 📒 Files selected for processing (5)
🚧 Files skipped from review as they are similar to previous changes (2)
🧰 Additional context used🧬 Code graph analysis (1)src/plugin/accounts.test.ts (1)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
🔇 Additional comments (4)
✏️ Tip: You can disable this entire section by setting Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (2)
docs/ANTIGRAVITY_API_SPEC.md (1)
4-4:⚠️ Potential issue | 🟡 MinorUpdate the "Last Updated" date.
The spec header still shows
December 13, 2025but the model availability table has been modified. Consider updating this to reflect the current change.src/plugin/transform/claude.test.ts (1)
57-58:⚠️ Potential issue | 🟡 MinorMissed 4-5 → 4-6 update on line 58.
Line 58 still references
Claude-Opus-4-5-Thinkingwhile all other opus references in this file have been updated to 4-6. This appears to be an oversight in the migration.Proposed fix
- expect(isClaudeThinkingModel("Claude-Opus-4-5-Thinking")).toBe(true); + expect(isClaudeThinkingModel("Claude-Opus-4-6-Thinking")).toBe(true);
🧹 Nitpick comments (1)
.opencode/plans/1770840700772-proud-garden.md (1)
62-77: Consider adding a search for alias/variant patterns in verification.The grep on line 75 only searches for
opus-4-5. You might also want to search foropus-4.5(with dot) oropus_4_5(with underscores) to catch any alternative formatting of the version string.Proposed addition to verification step
# 4. Verify no remaining references grep -r "opus-4-5" --include="*.ts" --include="*.md" --include="*.sh" --include="*.yml" # Should return 0 matches +grep -r "opus.4.5\|opus_4_5\|Opus 4.5" --include="*.ts" --include="*.md" --include="*.sh" --include="*.yml" --include="*.json" +# Should also return 0 matches
📜 Review details
Configuration used: Repository UI
Review profile: CHILL
Plan: Pro
Cache: Disabled due to data retention organization setting
Knowledge base: Disabled due to data retention organization setting
⛔ Files ignored due to path filters (1)
package-lock.jsonis excluded by!**/package-lock.json
📒 Files selected for processing (18)
.github/ISSUE_TEMPLATE/bug_report.yml.opencode/plans/1770840700772-proud-garden.mdAGENTS.MDREADME.mddocs/ANTIGRAVITY_API_SPEC.mdscript/test-cross-model-e2e.shscript/test-cross-model.tsscript/test-models.tsscript/test-regression.tssrc/plugin/accounts.test.tssrc/plugin/config/models.test.tssrc/plugin/config/models.tssrc/plugin/cross-model-integration.test.tssrc/plugin/request.tssrc/plugin/transform/claude.test.tssrc/plugin/transform/cross-model-sanitizer.test.tssrc/plugin/transform/model-resolver.test.tssrc/plugin/transform/model-resolver.ts
💤 Files with no reviewable changes (5)
- src/plugin/config/models.ts
- src/plugin/transform/model-resolver.ts
- script/test-models.ts
- .github/ISSUE_TEMPLATE/bug_report.yml
- src/plugin/config/models.test.ts
🧰 Additional context used
🧬 Code graph analysis (6)
script/test-cross-model.ts (2)
src/plugin/transform/index.ts (2)
getModelFamily(25-25)getModelFamily(66-66)src/plugin/transform/cross-model-sanitizer.ts (1)
getModelFamily(30-34)
src/plugin/transform/claude.test.ts (2)
src/plugin/transform/index.ts (2)
isClaudeModel(35-35)isClaudeThinkingModel(36-36)src/plugin/transform/claude.ts (2)
isClaudeModel(27-29)isClaudeThinkingModel(34-37)
src/plugin/cross-model-integration.test.ts (3)
src/plugin/transform/model-resolver.ts (1)
getModelFamily(270-279)src/plugin/transform/index.ts (2)
getModelFamily(25-25)getModelFamily(66-66)src/plugin/transform/cross-model-sanitizer.ts (1)
getModelFamily(30-34)
src/plugin/accounts.test.ts (1)
src/plugin/accounts.ts (1)
resolveQuotaGroup(249-254)
src/plugin/transform/cross-model-sanitizer.test.ts (3)
src/plugin/transform/model-resolver.ts (1)
getModelFamily(270-279)src/plugin/transform/index.ts (2)
getModelFamily(25-25)getModelFamily(66-66)src/plugin/transform/cross-model-sanitizer.ts (1)
getModelFamily(30-34)
src/plugin/transform/model-resolver.test.ts (1)
src/plugin/transform/model-resolver.ts (2)
resolveModelWithTier(159-265)resolveModelWithVariant(359-407)
🪛 LanguageTool
.opencode/plans/1770840700772-proud-garden.md
[uncategorized] ~54-~54: The official name of this software platform is spelled with a capital “H”.
Context: ...| Remove Opus 4.5 from model list | |.github/ISSUE_TEMPLATE/bug_report.yml:48` | Rem...
(GITHUB)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: Greptile Review
🔇 Additional comments (19)
AGENTS.MD (1)
7-7: LGTM! Model reference updated consistently with the broader migration.src/plugin/request.ts (1)
722-723: LGTM! Comment updated to reflect the new model version; logic unchanged.src/plugin/accounts.test.ts (1)
1838-1838: LGTM! Test input updated consistently;"claude-opus-4-6"still matches the"claude"family correctly.docs/ANTIGRAVITY_API_SPEC.md (1)
83-83: LGTM! Model availability table correctly updated from Opus 4-5 to Opus 4-6 with Verified status.src/plugin/transform/claude.test.ts (1)
19-19: LGTM! Model version strings updated consistently acrossisClaudeModelandisClaudeThinkingModeltests.Also applies to: 26-26, 32-32, 51-53, 63-63, 68-68
script/test-cross-model.ts (1)
62-62: LGTM! E2E test model references updated consistently.Also applies to: 75-75
src/plugin/transform/model-resolver.test.ts (2)
117-123: LGTM! Test correctly updated for the opus 4-6 thinking model with expected budget and quota settings.
211-218: LGTM! Backward compatibility tests updated consistently to 4-6 variants with correct budget expectations.src/plugin/transform/cross-model-sanitizer.test.ts (1)
14-14: LGTM! All cross-model sanitizer test expectations updated consistently to opus 4-6 variants.Also applies to: 304-304, 432-432, 519-519
README.md (3)
9-19: LGTM — model references and feature list updated consistently.All Claude Opus references updated from 4.5 to 4.6, and the new feature bullets are a welcome addition to the documentation.
118-125: Model table updated correctly.The
antigravity-claude-opus-4-5-thinkingrow has been replaced with the 4-6 variant.
195-203: Full config JSON updated correctly.The copy-paste-ready configuration now references
antigravity-claude-opus-4-6-thinking.script/test-cross-model-e2e.sh (1)
1-10: All model references updated consistently across all 8 test cases.The E2E script correctly replaces all
opus-4-5references withopus-4-6for bothanthropic/claude-opus-4-6andgoogle/antigravity-claude-opus-4-6-thinking-lowmodel identifiers.src/plugin/cross-model-integration.test.ts (4)
58-71: Test model references updated correctly.The
claude-opus-4-6-thinking-mediummodel string will be correctly identified bygetModelFamily(which checks for"claude"substring), so these test expectations remain valid.
130-199: Bug reproduction scenario updated consistently.Both the
modelfield andtargetModeloption correctly reference the 4-6 variant.
361-366: Model family detection test updated.The new model string
claude-opus-4-6-thinking-mediumis correctly expected to return"claude".
433-435: Batch format edge case test updated.Target model changed to
claude-opus-4-6— consistent with the migration.script/test-regression.ts (1)
55-58: CLAUDE_OPUS constant correctly updated.Only the Opus constant is changed to 4-6 while
CLAUDE_SONNET(sonnet-4-5) is correctly left unchanged, matching the scope of this deprecation..opencode/plans/1770840700772-proud-garden.md (1)
1-110: Well-structured migration plan.The plan thoroughly documents all affected files across source, tests, scripts, docs, and comments. The verification step with
grep -r "opus-4-5"is a good safeguard against missed references.
✏️ Tip: You can disable this entire section by setting review_details to false in your review settings.
Signed-off-by: Tito <github@mynameistito.com>
Greptile OverviewGreptile SummaryThis PR systematically removes all references to the deprecated Key changes:
Issue found:
The changes are well-structured and comprehensive, addressing the deprecation across all relevant areas of the codebase. Confidence Score: 4/5
Important Files Changed
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
18 files reviewed, 1 comment
Additional Comments (1)
Prompt To Fix With AIThis is a comment left during a code review.
Path: src/plugin/transform/claude.test.ts
Line: 58:58
Comment:
Missed reference - should use `Claude-Opus-4-6-Thinking`
```suggestion
expect(isClaudeThinkingModel("Claude-Opus-4-6-Thinking")).toBe(true);
```
How can I resolve this? If you propose a fix, please make it concise. |
Summary
Remove all references to Claude Opus 4.5 model (
claude-opus-4-5-thinking) from codebase since it has been deprecated on the Antigravity API. Users should use Claude Opus 4.6 instead.Changes
Source Code (2 files):
src/plugin/config/models.ts- Removedantigravity-claude-opus-4-5-thinkingdefinitionsrc/plugin/transform/model-resolver.ts- Removed 3 MODEL_ALIASES entries for opus-4-5 variantsTest Files (6 files):
src/plugin/transform/model-resolver.test.ts- Updated test expectations to use Opus 4.6src/plugin/transform/cross-model-sanitizer.test.ts- Updated model references to Opus 4.6src/plugin/transform/claude.test.ts- UpdatedisClaudeModel/isClaudeThinkingModeltestssrc/plugin/cross-model-integration.test.ts- Updated integration test modelssrc/plugin/config/models.test.ts- Removed Opus 4.5 from expected models listsrc/plugin/accounts.test.ts- Updated quota group testScripts (4 files):
script/test-regression.ts- UpdatedCLAUDE_OPUSconstant to Opus 4.6script/test-models.ts- Removed Opus 4.5 test entriesscript/test-cross-model.ts- Updated model references to Opus 4.6script/test-cross-model-e2e.sh- Updated all 8 shell script model references to Opus 4.6Documentation (4 files):
README.md- Updated model examples from Opus 4.5 to 4.6AGENTS.md- Updated overview to reference Opus 4.6docs/ANTIGRAVITY_API_SPEC.md- Removed Opus 4.5 from model list, marked 4.6 as verified.github/ISSUE_TEMPLATE/bug_report.yml- Removed Opus 4.5 from model dropdownComment Update (1 file):
src/plugin/request.ts- Updated comment example from Opus 4.5 to 4.6Verification
opus-4-5references in codebase (except this PR)Fixes #424