Add Documentation to all functions #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Enabled strict mode, add documentation and updated concatenated strings to es6 template strings
|
Thumbs up from me |
|
There are some typos on the text and I would try to stick to 80 columns, could you be able to fix them? Besides that it's an awesome work :-) |
|
Sure i will fix them, where are the typos |
|
Over all the text. If you give me permissions on your repo I could be able to fix them. |
|
Added you as collaborator. Sinne englisch is Not my native language this is very helpful |
Done :-) Do you want to review it, or we merge it directly? |
|
You can merge it directly |
|
Merged. Maybe we could add some tests here, too? :-) |
|
Im on it :D |
|
Cool! :-D |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enabled strict mode, add documentation and updated string interpolation to es6 template strings