fix: CI workflow errors and dependency vulnerabilities#182
Merged
Conversation
- Replace deprecated actions-rs/toolchain@v1 with dtolnay/rust-toolchain in all Rust CI jobs (test, test-rust, lint-rust, coverage-rust, audit-rust) - Replace deprecated actions-rs/tarpaulin@v0.1 with direct cargo install - Pin trufflesecurity/trufflehog to v3.95.7 instead of @main - Fix Rust toolchain version: switch from hardcoded 1.79.0 to 'toolchain: file' so rust-toolchain.toml (which pins 1.78.0) is the source of truth - Remove --no-verification flag from trufflehog args (conflicts with --results=verified,unknown) - Upgrade vitest 1.6.1 -> 3.2.6 (fixes critical esbuild CVE GHSA-67mh-4wv8-2f99) - Upgrade @opentelemetry/sdk-node 0.46.0 -> 0.219.0 (fixes high severity vuln) - Upgrade @opentelemetry/auto-instrumentations-node 0.46.0 -> 0.77.0 (fixes high) - Fix tests/stream.test.ts: add non-null assertion on mock.calls[0]! to satisfy noUncheckedIndexedAccess with updated vitest v3 type definitions
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes all errors in the CI workflow and resolves failing
audit-npmjob.CI Workflow fixes (
.github/workflows/ci.yml)actions-rs/toolchain@v1— archived/unmaintained actiondtolnay/rust-toolchain@masterin all 5 Rust jobsactions-rs/tarpaulin@v0.1— archived actioncargo install cargo-tarpaulin --locked+ direct runtrufflesecurity/trufflehog@main— unpinned, supply-chain riskv3.95.71.79.0butrust-toolchain.tomlpins1.78.0toolchain: file—rust-toolchain.tomlis now the single source of truth--no-verificationflag contradicts--results=verified,unknownin trufflehog args--no-verificationDependency fixes (
package.json)vitest1.6.13.2.6@opentelemetry/auto-instrumentations-node0.46.00.77.0@opentelemetry/sdk-node0.46.00.219.0npm audit --audit-level=highnow returnsfound 0 vulnerabilities.Test fix (
tests/stream.test.ts)Added
!non-null assertion onmock.calls[0]!— vitest v3 updated its type definitions to correctly reflectnoUncheckedIndexedAccess, which the prior v1 types silently ignored.